? ? Pending

User tests: Successful: Unsuccessful:

avatar bembelimen
bembelimen
2 Jan 2021

Pull Request for Issue #30015 .

Summary of Changes

Remove all "captionTable" IDs

Testing Instructions

Test by review? No duplicate ID in tinyMCE plugin

Actual result BEFORE applying this Pull Request

"captionTable" IDs everywhere

Expected result AFTER applying this Pull Request

"captionTable" IDs nowhere

avatar bembelimen bembelimen - open - 2 Jan 2021
avatar bembelimen bembelimen - change - 2 Jan 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 2 Jan 2021
Category Administration com_associations com_banners com_cache com_categories com_checkin com_contact com_content com_contenthistory com_csp com_fields com_finder com_installer
avatar richard67
richard67 - comment - 2 Jan 2021

I have tested this item successfully on 2222f76

I can confirm that

  • This PR removes all occurrences of id="captionTable", i.e. nothing forgotten.
  • The string "captionTable" doesn't occur anywhere else, so it seems not to be used by any js/(s)css files.

No idea why that was there.
The patchtester uses it, too.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31829.

avatar richard67 richard67 - test_item - 2 Jan 2021 - Tested successfully
avatar chmst
chmst - comment - 2 Jan 2021

I have tested this item successfully on 2222f76

By code review. The ID is not used anywhere and has nothing to do with a11y.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31829.

avatar chmst chmst - test_item - 2 Jan 2021 - Tested successfully
avatar richard67 richard67 - change - 2 Jan 2021
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 2 Jan 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31829.

avatar richard67 richard67 - change - 2 Jan 2021
Labels Added: ? ?
avatar drmenzelit drmenzelit - change - 2 Jan 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-01-02 14:45:18
Closed_By drmenzelit
Labels
avatar drmenzelit drmenzelit - close - 2 Jan 2021
avatar drmenzelit drmenzelit - merge - 2 Jan 2021
avatar drmenzelit
drmenzelit - comment - 2 Jan 2021

Thanks

Add a Comment

Login with GitHub to post a comment