Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#31438] - [4.0] Searchtools works with selects only

NPM Resource Changed ? ? Pending

User tests: Successful: Unsuccessful:

avatar Denitz
Denitz
20 Nov 2020

Summary of Changes

Currently, searchtools script is not 100% ready for having non-select filters.

Testing Instructions

Use filter form with non-select fields, try text and number fields types.
The fastest way is to change an existing filter form and change field types.

Actual result BEFORE applying this Pull Request

Once a filter has any value, the Clear button is disabled.

Expected result AFTER applying this Pull Request

Once a filter has any value, the Clear button is not disabled.

Documentation Changes Required

No.

2bbe487 20 Nov 2020 avatar Denitz fix
avatar Denitz Denitz - open - 20 Nov 2020
avatar Denitz Denitz - change - 20 Nov 2020
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 20 Nov 2020
Category ⇒ JavaScript Repository NPM Change
avatar Denitz Denitz - change - 23 Nov 2020
Labels Added: NPM Resource Changed ?
avatar Denitz
Denitz - comment - 23 Nov 2020

@Quy Fixed.

avatar ceford
ceford - comment - 3 Jan 2021

After applying the patch and changing Articles list Depth to Text I see that the Clear button is not disabled but it does not work either. I get this Javascript error:
Uncaught TypeError: Cannot read property 'undefined' of undefined
at Searchtools.activeFilter (searchtools.js?213f32181bd1349a270e2048e65c8a57:326)
at Searchtools.checkFilter (searchtools.js?213f32181bd1349a270e2048e65c8a57:222)
at searchtools.js?213f32181bd1349a270e2048e65c8a57:167
at Array.forEach ()
at new Searchtools (searchtools.js?213f32181bd1349a270e2048e65c8a57:166)
at HTMLDocument.onBoot (searchtools.js?213f32181bd1349a270e2048e65c8a57:538)
Is that what is expected?

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31438.

avatar Denitz
Denitz - comment - 4 Jan 2021

@ceford Sorry, found an issue, please re-try.

avatar ceford
ceford - comment - 4 Jan 2021

I have tested this item ✅ successfully on 0d084c4

This time, setting Articles / Level to type Text I find that the clear button works and clears whatever I have entered in that field as well as drop-down list field.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31438.

avatar ceford ceford - test_item - 4 Jan 2021 - Tested successfully
avatar gostn
gostn - comment - 10 Jan 2021

I have tested this item ✅ successfully on 0d084c4

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31438.

avatar gostn gostn - test_item - 10 Jan 2021 - Tested successfully
avatar infograf768
infograf768 - comment - 10 Jan 2021

I have tested this item ✅ successfully on 0d084c4

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31438.

avatar infograf768 infograf768 - test_item - 10 Jan 2021 - Tested successfully
avatar infograf768 infograf768 - change - 10 Jan 2021
Status Pending ⇒ Ready to Commit
avatar infograf768
infograf768 - comment - 10 Jan 2021

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31438.

avatar drmenzelit drmenzelit - change - 12 Jan 2021
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2021-01-12 09:57:55
Closed_By ⇒ drmenzelit
Labels Added: ?
avatar drmenzelit drmenzelit - close - 12 Jan 2021
avatar drmenzelit drmenzelit - merge - 12 Jan 2021
avatar drmenzelit
drmenzelit - comment - 12 Jan 2021

Thanks

Add a Comment

Login with GitHub to post a comment