?
avatar shoulders
shoulders
20 Nov 2020

The following field does not appear to be used in com_contact anywhere and I do not understand what the @ sign is for either.

<field
name="@text_details"
type="note"
label=""
description="COM_CONTACT_EDIT_DETAILS"
/>

The JTEXT reference is:

COM_CONTACT_EDIT_DETAILS="Edit contact information displayed on an individual page."

I have done a text search in com_contact I have and cannot find this text_details

What now

I think this should be removed

Other notes

it appears to be an issue in J4 (but I have not looked properly at J4)

<field
name="@text_details"
type="note"
label=""
description="COM_CONTACT_EDIT_DETAILS"
/>

JTEXT

COM_CONTACT_EDIT_DETAILS="Edit contact information displayed on an individual page."

System Details

Setting Value
 
PHP Built On Windows NT E6540 10.0 build 19041 (Windows 10) AMD64
Database Type mysql
Database Version 5.5.5-10.4.10-MariaDB
Database Collation utf8mb4_unicode_ci
Database Connection Collation utf8mb4_general_ci
PHP Version 7.3.12
Web Server Apache/2.4.41 (Win64) OpenSSL/1.1.1c PHP/7.3.12
WebServer to PHP Interface apache2handler
Joomla! Version Joomla! 3.9.22 Stable [ Amani ] 6-October-2020 15:00 GMT
Joomla! Platform Version Joomla Platform 13.1.0 Stable [ Curiosity ] 24-Apr-2013 00:00 GMT
User Agent Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:82.0) Gecko/20100101 Firefox/82.0
avatar shoulders shoulders - open - 20 Nov 2020
avatar joomla-cms-bot joomla-cms-bot - change - 20 Nov 2020
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 20 Nov 2020
avatar shoulders shoulders - change - 20 Nov 2020
The description was changed
avatar shoulders shoulders - edited - 20 Nov 2020
avatar drmenzelit drmenzelit - change - 20 Nov 2020
Title
unused field in com_contact contact.xml form
[3.9] unused field in com_contact contact.xml form
avatar drmenzelit drmenzelit - edited - 20 Nov 2020
avatar Bakual
Bakual - comment - 20 Nov 2020

Looks indeed like a leftover. It got introduced with 6234151, but that was just some sync merge of another branch.
The language string itself goes back even further (year 2010).

So I think this field indeed can be safely removed. Do you want to prepare a PR?

avatar shoulders
shoulders - comment - 20 Nov 2020

@Bakual if you are asking me to prepare a PR I have not got to that stage of my coding development yet. I am just building my first component, so maybe after I have graduated from that i can start doing these. ?

Also this issue is present in J3 and J4

avatar Bakual
Bakual - comment - 20 Nov 2020

See #31439

avatar alikon alikon - change - 20 Nov 2020
Status New Closed
Closed_Date 0000-00-00 00:00:00 2020-11-20 15:28:51
Closed_By alikon
avatar alikon alikon - close - 20 Nov 2020

Add a Comment

Login with GitHub to post a comment