? ? Pending

User tests: Successful: Unsuccessful:

avatar Bakual
Bakual
20 Nov 2020

Pull Request for Issue #31437 .

Summary of Changes

Removes the contact field text_details which isn't used.

Looks like it is a leftover from very old days.

Testing Instructions

Edit a contact

Actual result BEFORE applying this Pull Request

No such field

Expected result AFTER applying this Pull Request

No such field, contact still works the same.

Documentation Changes Required

None

avatar Bakual Bakual - open - 20 Nov 2020
avatar Bakual Bakual - change - 20 Nov 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 20 Nov 2020
Category Administration com_contact
avatar infograf768
infograf768 - comment - 20 Nov 2020

Worth correcting Hathor for the unwanted sprintf as the string does not contain any variable?

<p><?php echo empty($this->item->id) ? JText::_('COM_CONTACT_DETAILS') : JText::sprintf('COM_CONTACT_EDIT_DETAILS', $this->item->id); ?></p>

Screen Shot 2020-11-20 at 18 00 40

avatar toivo toivo - test_item - 20 Nov 2020 - Tested successfully
avatar toivo
toivo - comment - 20 Nov 2020

I have tested this item successfully on a91e5b0

Tested successfully in 3.9.22.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31439.

avatar ChristineWk ChristineWk - test_item - 20 Nov 2020 - Tested successfully
avatar ChristineWk
ChristineWk - comment - 20 Nov 2020

I have tested this item successfully on a91e5b0


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31439.

avatar Bakual
Bakual - comment - 20 Nov 2020

Worth correcting Hathor for the unwanted sprintf as the string does not contain any variable?

Didn't even notice the variable. I just thought I leave that string alone as it will go away with J4 anyway (due to removing of Hathor).

avatar infograf768
infograf768 - comment - 21 Nov 2020

Didn't even notice the variable. I just thought I leave that string alone as it will go away with J4 anyway (due to removing of Hathor).

The string should be deleted in j4. Will make PR.

avatar infograf768 infograf768 - change - 21 Nov 2020
Status Pending Ready to Commit
avatar infograf768
infograf768 - comment - 21 Nov 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/31439.

avatar infograf768
infograf768 - comment - 21 Nov 2020

See #31448

avatar richard67 richard67 - change - 21 Nov 2020
Labels Added: ? ?
avatar infograf768 infograf768 - change - 25 Nov 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-11-25 09:21:38
Closed_By infograf768
Labels
avatar infograf768 infograf768 - close - 25 Nov 2020
avatar infograf768 infograf768 - merge - 25 Nov 2020
avatar infograf768
infograf768 - comment - 25 Nov 2020

tks

Add a Comment

Login with GitHub to post a comment