[#30573] - Show exception messages on media error
- Fixed in Code Base
- 6 Sep 2020
- Medium
- Build: 4.0-dev
- # 30573
- Diff
- maliouris:show-exception-messages-on-media-error
User tests: Successful: Unsuccessful:
Pull Request for Issue #25379
Summary of Changes
In com_media change _handleError js function in order to show error messages if there are any thrown by an exception, otherwise show some defaults based on error code.
Testing Instructions
Run:
npm run dev:com_media
npm run build:js
reload browser with: CTL+F5
Set max file size to 1 and upload a larger file
Actual result BEFORE applying this Pull Request
Error message will show "You are not authorized"
Expected result AFTER applying this Pull Request
Error message This file is too large to upload.
Documentation Changes Required
Some other constants may have to be declared to /administrator/language/en-GB as /language/en-GB files are not loaded in the administrator view
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript Administration com_media NPM Change Language & Strings Repository |
| Title |
|
||||||
i've applyed the patch
then i've runned npm ci
but uploading a large img give me this result:
what i'm missing ?
Can you give me more info ? Because in my point of view I see this:
Did you run "npm run dev:com_media" and "npm run build:js" ? If you did just tell my all the steps to reproduce it.
(Also refresh your browser page CTL+F5 in order to load the compiled js)
ok after running
npm run dev:com_media
npm run build:js
plus
CTL+F5
i've got the expected results
thank you..... maybe better to update the Testing Instructions
to help dumb people like me
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30573.
Message should not be in upper case.
| Labels |
Added:
?
NPM Resource Changed
?
|
||
Message should not be in upper case.
I resolved it. You can check again
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30573.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30573.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30573.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-09-06 08:55:53 |
| Closed_By | ⇒ | infograf768 | |
| Labels |
Added:
?
|
||
I just had to use npm ci
Thanks.
i've applyed the patch
then i've runned npm ci
but uploading a large img give me this result:
what i'm missing ?