? ? Pending

User tests: Successful: Unsuccessful:

avatar maliouris
maliouris
4 Sep 2020

Pull Request for Issue #30567

Summary of Changes

Check if maximum file size is set to 0 and let user upload the image, else check if file size is larger than the maximum file size and throw error

Testing Instructions

Set maximum file size to 0.

Actual result BEFORE applying this Pull Request

Can't upload any image

Expected result AFTER applying this Pull Request

Upload images as expected

Documentation Changes Required

avatar maliouris maliouris - open - 4 Sep 2020
avatar maliouris maliouris - change - 4 Sep 2020
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 4 Sep 2020
Category Administration com_media
avatar Formatio-hippocampi Formatio-hippocampi - test_item - 5 Sep 2020 - Tested successfully
avatar Formatio-hippocampi
Formatio-hippocampi - comment - 5 Sep 2020

I have tested this item successfully on 84e1f80


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30572.

avatar alikon alikon - test_item - 5 Sep 2020 - Tested successfully
avatar alikon
alikon - comment - 5 Sep 2020

I have tested this item successfully on 84e1f80


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30572.

avatar alikon alikon - change - 5 Sep 2020
Status Pending Ready to Commit
avatar alikon
alikon - comment - 5 Sep 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30572.

avatar richard67 richard67 - change - 5 Sep 2020
Labels Added: ? ?
avatar paternax paternax - test_item - 5 Sep 2020 - Tested successfully
avatar paternax
paternax - comment - 5 Sep 2020

I have tested this item successfully on 84e1f80


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30572.

avatar Quy Quy - change - 5 Sep 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-09-05 16:30:56
Closed_By Quy
Labels
avatar Quy Quy - close - 5 Sep 2020
avatar Quy Quy - merge - 5 Sep 2020
avatar Quy
Quy - comment - 5 Sep 2020

Thank you!

avatar wilsonge
wilsonge - comment - 5 Sep 2020

Thankyou for you first PR to joomla ❤️

avatar maliouris
maliouris - comment - 5 Sep 2020

Thank you, although It's not my first PR to joomla

Add a Comment

Login with GitHub to post a comment