Feeling Lucky
?
?
[#30574] - [4.0] Store memory and time as float in Profiler
- Fixed in Code Base
- 15 Sep 2020
- Medium
- Build: 4.0-dev
- # 30574
- Diff
- SharkyKZ:j4/php8/profiler
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
Changes mark memory and time format from improperly formatted string to float.
Testing Instructions
Enable debug on PHP 8.
Actual result BEFORE applying this Pull Request
abs(): Argument #1 ($number) must be of type int|float, string given
Expected result AFTER applying this Pull Request
No errors.
Documentation Changes Required
Maybe?
Additional Comments
We also need something like this for staging (can be done without changing data type), waiting for response in #29353.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
jwaisner
- comment
- 13 Sep 2020
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30574.
| Status | Pending | ⇒ | Ready to Commit |
Quy
- comment
- 13 Sep 2020
RTC
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-09-15 11:23:38 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
?
|
||
wilsonge
- comment
- 15 Sep 2020
Thanks!
I have tested this item✅ successfully on 5501f71
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30574.