[#30575] - [4.0] Error in legacy plugins when method contains $event argument
- Fixed in Code Base
- 29 Sep 2020
- Medium
- Build: 4.0-dev
- # 30575
- Diff
- SharkyKZ:j4/bug/plugin-event
User tests: Successful: Unsuccessful:
Summary of Changes
Fixes legacy plugins being registered as modern plugins when method takes $event argument.
Testing Instructions
install and enable this plugin: plg_system_dummy.zip.
Actual result BEFORE applying this Pull Request
Argument 1 passed to PlgSystemDummy::onDummyTest() must be of the type string, object given
Expected result AFTER applying this Pull Request
No errors.
Documentation Changes Required
No.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Labels |
Added:
?
|
||
That's expected behavior before patch.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30575.
That's expected behavior before patch.
Of course, the message before patch was expected, but not, that my site becomes complety broken.
What I did:
At first I deleted the dummy plugin via phpMyAdmin successfully & backend was available again.
The possibility for an update tor 4.0.0-beta5 was shown > but unsuccessful, because got: AJAX Loading error ...
(Correct server nightly xml)
Therefore I deleted space/database and installed fully nightly 4.0.0-beta5 plus Patchtester etc.
Then activated this Patch (did not check now message before Patch :-)
Installed your Dummy plugin and Result: No failure/message.
Hmmm: After successful Patch (see above) I reverted it and got the failure again. Backend broken now.
Will try to delete dummy Plugin via phpMyAdmin again.
For other testers: Please before reverting Patch: de-active Plugin ....
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30575.
I hope you're not testing on live site
I hope you're not testing on live site
?
It's a live site (space), but for testing purposes only of course :-)
Will never forget your plugin -hv deleted it now :-)
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30575.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30575.
Conflicts here...
| Labels |
Added:
?
|
||
Conflicts fixed.
Last commit changes condition order for optimization. No change in functionality.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-09-29 11:08:21 |
| Closed_By | ⇒ | laoneo |
Thanks!
@SharkyKZ
Installed dummy plugin. Joomla 4.0.0-beta4
Before Patch:
0 Argument 1 passed to PlgSystemDummy::onDummyTest() must be of the type string, object given, called in /......./libraries/vendor/joomla/event/src/Dispatcher.php on line 495
Couldn't return to Dashboard & now site is broken.
Will install tomorrow a new fully nightly (4.0.0-beta5)
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30575.