Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#30576] - [4.0] Add stricter comparison and unification of variable client_id

? Pending

User tests: Successful: Unsuccessful:

avatar astridx
astridx
5 Sep 2020

Summary of Changes

Add stricter comparison and unification of variable client_id in administrator/components/com_modules/src/View/Modules/HtmlView.php

Testing Instructions

Code review

6f68a3d 5 Sep 2020 avatar astridx wip
avatar astridx astridx - open - 5 Sep 2020
avatar astridx astridx - change - 5 Sep 2020
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 5 Sep 2020
Category ⇒ Administration com_modules
avatar ChristineWk ChristineWk - test_item - 6 Sep 2020 - Tested successfully
avatar ChristineWk
ChristineWk - comment - 6 Sep 2020

I have tested this item ✅ successfully on 6f68a3d

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30576.

avatar infograf768
infograf768 - comment - 6 Sep 2020

Maybe also change line 157 to
->onclick("location.href='index.php?option=com_modules&view=select&client_id=" . $this->clientId . "'");

af19f4d 11 Sep 2020 avatar astridx wip
avatar astridx astridx - change - 11 Sep 2020
Labels Added: ? ?
avatar astridx
astridx - comment - 11 Sep 2020

Maybe also change line 157 to
->onclick("location.href='index.php?option=com_modules&view=select&client_id=" . $this->clientId . "'");

I wanted to avoid that because there could be conflict with #30577. But have now added it.

avatar astridx
astridx - comment - 20 Sep 2020

Looks like not much are interested.

avatar astridx astridx - change - 20 Sep 2020
Status Pending ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2020-09-20 13:01:50
Closed_By ⇒ astridx
Labels Removed: ?
avatar astridx astridx - close - 20 Sep 2020

Add a Comment

Login with GitHub to post a comment