I have tested this item ✅ successfully on e1a1de0

This PR results in the loss of the quicktask link for creating a new module. I would be sad to see this go

Quick icon needs to be updated.

I took off the administrator modules menu item from alternate.xml
Then, I used the Modules menu item and chose Administrator as client, then New:

Although the correct Modules list is displayed, the manager title is always Modules (Site) instead of Modules (Administrator)

@brianteeman This PR results in the loss of the quicktask link for creating a new module. I would be sad to see this go

Yes you are right. This is a pity.
But, if there is only one link in the side menu, quicktask would be confusing, right? You then don't know whether a site or admin module is being created. Do you have a suggestion? Of course it is easier with two menu item entries (one for site and one for admin). But the way I see it, this is only possible with a GET variable. With a GET variable in the URL, however, any filters that may have been set are not deleted. Or do you see a possibility there?

@Quy Quick icon needs to be updated.

Thanks, I missed that. Now I've corrected it.

@SharkyKZ On glip your wrote, that there is no need to remove site/client module URLs, because this can be fixed in the model alone.

Thanks for checking. I have tried this #30323 and explained here why I think this is in my opinion not possible. What am I missing? Can you give me a hint how I can implement it?

@infograf768 I took off the administrator modules menu item from alternate.xml
Then, I used the Modules menu item and chose Administrator as client, then New:

Although the correct Modules list is displayed, the manager title is always Modules (Site) instead of Modules (Administrator)

Thanks, I missed alternate.xml. Now I've corrected it.

Can you explain to me in more detail which title is incorrect? It looks right for me. See pictures. But maybe I get you wrong.

But, if there is only one link in the side menu, quicktask would be confusing, right?

Make it same as the Modules quick icon.

@astridx

Can you explain to me in more detail which title is incorrect? It looks right for me. See pictures. But maybe I get you wrong.

@astridx I don't have an exact solution yet. Using client ID from request when building context key or clearing filters when client ID has changed could work. In any case, we have more instances like this (e.g. template styles).

clearing filters when client ID has changed could work

That would be ideal so we can keep quicktasks.

I have tested this item ✅ successfully on abb778f

I am not sure about this. When I change from Site to Administrator I see the filter being cleared before page load. That is probably as annoying as not clearing the filters. Otherwise, it seems to work.

But, if there is only one link in the side menu, quicktask would be confusing, right?

@Quy Make it same as the Modules quick icon.

I inserted quicktast again in all presets. like you suggested.

@ceford I am not sure about this. When I change from Site to Administrator I see the filter being cleared before page load. That is probably as annoying as not clearing the filters. Otherwise, it seems to work.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/30577.

If I understand you correctly, then it has to be like this, otherwise wrong data would be loaded (or they have to be loaded twice). The elements in the list are loaded using the filters. Did I understand you correctly?

@infograf768

Although the correct Modules list is displayed, the manager title is always Modules (Site) instead of Modules (Administrator)

Thank you. I corrected the title.

@SharkyKZ astridx I don't have an exact solution yet. Using client ID from request when building context key or clearing filters when client ID has changed could work. In any case, we have more instances like this (e.g. template styles).

But isn't it also wrong with template styles? See
#30302 (comment)

In the quick icon, the tooltip for the + icon is "Add Site Module" which is not correct depending on the current module type selected.

@Quy uy In the quick icon, the tooltip for the + icon is "Add Site Module" which is not correct depending on the current module type selected.

Thanks done.

But isn't it also wrong with template styles? See
#30302 (comment)

Yes, it's wrong. But this should be fixed instead of being stripped out.

5. Use different presets and check, that these work correct.

I have tested this item ? unsuccessfully on 00f8d52

1. Go to Menu Dashboard
2. Click on Add module to the dashboard
3. Select a Module Type
4. At Top of Modal-Windows Part of Admin-Template and at Bottom Buttons Close, Save & Close are shown. Click on Save & Close at Bottom didn't work:

System Information

php: Linux lamp131.cloudaccess.net 3.10.0-714.10.2.lve1.5.17.el6h.x86_64 #1 SMP Mon Apr 30 13:48:47 EDT 2018 x86_64
dbserver: mysql
dbversion: 5.7.24-cll-lve
dbcollation: utf8_general_ci
dbconnectioncollation: utf8mb4_general_ci
dbconnectionencryption:
dbconnencryptsupported: false
phpversion: 7.3.21
server: Apache
sapi_name: cgi-fcgi
version: Nightly Build - Joomla! 4.0.0-beta4-dev Development [ Mañana ] 29-July-2020 18:21 GMT
useragent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:80.0) Gecko/20100101 Firefox/80.0

I have tested this item ? unsuccessfully on 00f8d52

1. Go to `Menu Dashboard`

2. Click on `Add module to the dashboard`

3. Select a Module Type

4. At Top of Modal-Windows Part of Admin-Template and at Bottom Buttons `Close`, `Save & Close` are shown. Click on `Save & Close` at Bottom didn't work:

I can't confirm this problem. The Save&Close worked in the scenario Formation h. described.

I have tested this item ✅ successfully on 00f8d52

I confirm @Formatio-hippocampi findings
This PR breaks inserting a module when using the bottom buttons.
It works when using the toolbar top buttons but does not display at once. Page has to be reloaded to see the new module.

Displaying the status and the toolbar in the modal window is wrong.

I have tested this item ? unsuccessfully on 00f8d52

It looks like the issue comes from
/administrator/components/com_modules/tmpl/select/default.php line 61

I solved it by using
<?php $link = 'index.php?option=com_modules&task=module.add&eid=' . $item->extension_id . $this->modalLink; ?>

instead of
<?php $link = 'index.php?option=com_modules&task=module.add&eid=' . $item->extension_id; ?>

Thank you @Formatio-hippocampi and @infograf768 . I did not see that. I have corrected it.
A module can now also be correctly added via "add module to the dashboard".

I have tested this item ✅ successfully on 17da55f

Works OK now but I still think that clearing filters when client ID has changed would be a better solution.

I have tested this item ✅ successfully on 17da55f

Hello:

I've followed Testing Instructions, first without applying the path and then applying it. Now, when I back to modules list, I see modules.

Tested with Joomla Beta 5-dev and PHP 7.3.22.

Thank you!

I have tested this item ? unsuccessfully on 17da55f

Before

After

@brianteeman
Thank you for testing. Can you explain in short words what you mean?

as shown in the video if the last module manager page was with the admin modules selected then the add new module on the dashboard will offer to create a new admin module instead of a site module

@brianteeman

as shown in the video if the last module manager page was with the admin modules selected then the add new module on the dashboard will offer to create a new admin module instead of a site module

I like this. Why do you think it is a failure?

Simple. A link must always go to the same predictable place. If nothing else it is an accessibility failure and an unexpected behaviour that a link doesnt go where you think it will go because of an action you performed 4 hours earlier.

OK. I am no a11y expert. Then I close this here

Hello:

I understand Brian, a link should be predictable, OK. But current behaviour, an empty list after using some filters (issue #30302), is not correct.

I think this solution by @astridx is the best we have right now. User has played with the filters by himself, so the link has not an terrible accessibility issue, user goes to a predictable place for him. I think it's the behaviour J3 has since years ago and it's useful.

Thank you and best regards