Feeling Lucky
NPM Resource Changed
?
[#28695] - [4.0] Remove closest and matches polyfills
- Fixed in Code Base
- 16 Apr 2020
- Medium
- Build: 4.0-dev
- # 28695
- Diff
- C-Lodder:js-stuff
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #25186
Summary of Changes
This removes the custom polyfills for the closest() and matches() methods and replaces with the the native JS methods
Testing Instructions
- Ensure you can unpublish a module in the admin dashboard and it's removed
- Ensure subform fields work as expected
- Ensure the sidebar menu works the same as before
Or:
Code review
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript Repository NPM Change |
| Labels |
Added:
NPM Resource Changed
?
|
||
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-04-16 11:59:25 |
| Closed_By | ⇒ | wilsonge |
Quy
- comment
- 21 Apr 2020
To reproduce, go to Global Configuration > Users > Email Domain Options, click + icon.
TypeError: row is null
/media/system/js/fields/joomla-field-subform.js:107
row = row.closest('joomla-field-subform') === that ? row : null;
Quy
- comment
- 21 Apr 2020
Firefox 75.0 Windows 10
wilsonge
- comment
- 22 Apr 2020
Started going through the full requirements list two weeks ago to get formal approval from production. Right now my intention is no ie11 support. But that’s still to be fully confirmed based on their vote
Thanks!