[#28696] - [4.0] Fix JS error in codemirror
- Fixed in Code Base
- 16 Apr 2020
- Medium
- Build: 4.0-dev
- # 28696
- Diff
- C-Lodder:patch-1
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Pull Request for Issue comment in #28211 (comment)
Summary of Changes
Note: This does NOT close the issue above, it's just a fix.
In JS, you cannot call a static function from within the instance using this.foo().
Testing Instructions
- Go to the Plugin manager
- Open the Codemirror plugin and navigate to the "Appearance" tab
- Click anywhere in the gutter (within red box in screenshot below)
Expected result
Clicking the gutter should add a dot marker
Actual result
JS error
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript Repository NPM Change |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28696.
I have tested this item
I got the js error mentioned at #28211 (comment) when making click on the grey area just next to the code
When I tried to apply this patch from the patch tester, I got the following error
The patch could not be applied because it would break the site. Check the pull request to see if it is up-to-date.
I was using Patch Tester component version 4.0.0-rc2 04-April-2020
My Joomla version is Joomla version, 4.0.0-beta1-dev.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28696.
@BertaOctech You need to run node build.js --compile-js from your terminal before testing
Sorry I should have mentioned that before
I have tested this item
No JS error now.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28696.
They will probably be fixed if you update your branch to include the recent commit from George
| Labels |
Added:
NPM Resource Changed
?
|
||
Merged 4.0-dev into my branch. No idea why Drone is still failing for MySQL tests, but not something I can do anything about as this PR only changes a JS file
Looks like the drone errors are not related to this PR. It is calling out a connectivity problem with Webdriver. I will retest just to confirm it works as expected.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28696.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/28696.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-04-16 21:47:08 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
Thanks. Drone failed to start the webdriver itself.
I "guess" the issue arose when the code was converted from jquery in j3 to es6 here