@Hackwar Just a question from reading: Ist it correct that the first check if $source is true applies only to the first || condition in lines 128 and 129?

if ($source && (\is_object($source) && get_class($source) == 'GdImage')
	|| (\is_resource($source) && get_resource_type($source) == 'gd'))

Or should it apply in both of the cases separated by the || as follows:

if ($source && (\is_object($source) && get_class($source) == 'GdImage'
	|| \is_resource($source) && get_resource_type($source) == 'gd'))

As I said, just a question from reading, maybe all is fine as is it.

No, that is fine the way it is. $source can be null and get_class(null) (or anything not an object) will throw an error.

Anyhow, with this PR and the bunch of changes we did to drone and the docker images used, I can now happily proclaim that we are passing all tests.

hmm can you think of any reason that RIPS would complain about files in this path: libraries/vendor/hoa I don't see that this PR touches anything around that path and is also not introducing new composer deps as well as this path does not seem to be included in with an composer install?

@zero-24 seems to be a RIPS glitch. Whitelisted the issues and restarted the build

We should be consistent on how we handle this. I think its enough if we check for object and resource (including type) and not for the php version. Also please add a comment that resource can be removed if we only support php 8+

I added the comments and unified the handling. Please review again and give thumbs up/down.

Thanks