? Pending

User tests: Successful: Unsuccessful:

avatar Fedik
Fedik
17 Nov 2019

Pull Request for Issue #27083

Summary of Changes

Update Choices.js to latest version, also it fix a placeholder for a select with multiple attribute

Testing Instructions

apply patch, run npm install

Expected result

all works, with new version

Actual result

all works, with old version

Documentation Changes Required

none

avatar Fedik Fedik - open - 17 Nov 2019
avatar Fedik Fedik - change - 17 Nov 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 17 Nov 2019
Category JavaScript Repository NPM Change
avatar wilsonge
wilsonge - comment - 17 Nov 2019

@SniperSister @zero-24 can you look at RIPS please

avatar Quy Quy - test_item - 17 Nov 2019 - Tested successfully
avatar Quy
Quy - comment - 17 Nov 2019

I have tested this item successfully on 19ea649


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27093.

avatar ghazal ghazal - test_item - 18 Nov 2019 - Tested successfully
avatar ghazal
ghazal - comment - 18 Nov 2019

I have tested this item successfully on 19ea649


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27093.

avatar brianteeman brianteeman - test_item - 18 Nov 2019 - Tested successfully
avatar brianteeman
brianteeman - comment - 18 Nov 2019

I have tested this item successfully on 19ea649


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27093.

avatar brianteeman
brianteeman - comment - 18 Nov 2019

Thanks @Fedik


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27093.

avatar Quy Quy - change - 18 Nov 2019
Status Pending Ready to Commit
avatar Quy
Quy - comment - 18 Nov 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27093.

avatar wilsonge wilsonge - change - 18 Nov 2019
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-11-18 13:51:11
Closed_By wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 18 Nov 2019
avatar wilsonge wilsonge - merge - 18 Nov 2019
avatar wilsonge
wilsonge - comment - 18 Nov 2019

Thanks!

Add a Comment

Login with GitHub to post a comment