[#27094] - [4.0][API][com_actionslogs] keep track of API requests
- Fixed in Code Base
- 24 Mar 2020
- Medium
- Build: 4.0-dev
- # 27094
- Diff
- alikon:patch-122
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Summary of Changes
listen event onAfterDispatch to keep track of API requests on actionlogs
Testing Instructions
make some requests GET for example:
/api/index.php/v1/plugins
/api/index.php/v1/users
/api/index.php/v1/config/application
/api/index.php/v1/content/article
....
etc...
test other verbs as welll
Expected result
API requests logged
something like
Actual result
N/A
Documentation Changes Required
maybe
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Language & Strings Libraries Front End Plugins |
| Labels |
Added:
?
?
|
||
| Category | Administration Language & Strings Libraries Front End Plugins | ⇒ | Administration Language & Strings Front End Plugins |
yes again
there is no need for a new event onAfterDispatch does already the job
Looks good to me. Just needs some tests
Please fix conflicts.
| Labels |
Added:
Conflicting Files
|
||
conflict solved
User admin performed a GET on index.php/v1/modules/site?language=%2A&state=0
* is displayed as %2A
| Labels |
Removed:
Conflicting Files
|
||
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-02-12 19:35:43 |
| Closed_By | ⇒ | alikon | |
| Labels |
Added:
?
|
||
| Status | Closed | ⇒ | New |
| Closed_Date | 2020-02-12 19:35:43 | ⇒ | |
| Closed_By | alikon | ⇒ |
| Status | New | ⇒ | Pending |
Tested with different words, for example
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27094.
Having thought about this I think we probably want to have an additional flag for this API setting. Because in the case you have mobile apps using the API actively you're going to end up having too many entries in action logs. But you might well still want other actions logged in the component.
Tests ran:
Results:
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27094.
| Labels |
Removed:
?
|
||
ok i've fine grained the api logging
now you can disable the api logging
you can enable only some verbs to be logged
and of course only on some "Events"
I have tested this item
GET: ok
POST: ok
DELETE: ok
PUT: not tested (if someone have an example I try it)
PATCH: non listed in "Verds to log" ( I test this example: https://docs.joomla.org/J4.x:Joomla_Core_APIs#Update_Article)
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27094.
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-03-24 11:38:27 |
| Closed_By | ⇒ | wilsonge |
Thanks!
thanks folks + thanks to covid19 for lockdown
Does this REALLY need a new event? Couldn’t
onAfterDispatchwork just as well here? You’d just need to check context if using that event.