Feeling Lucky
?
?
[#27095] - [4.0] Remove banner alias
- Closed
- 28 Nov 2019
- Medium
- Build: 4.0-dev
- # 27095
- Diff
- brianteeman:banners
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
The banners component has an alias field for the banner title. This is never used anywhere and is probably a result of copy pasting another component in the dim and distant past. It is crazy to maintain code that is not used so this PR removes the alias field.
Testing
- Create/edit banner
- save as new banner
- batch copy banners
- batch move banners
Pull Request for Issue #26843
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | SQL Administration com_admin Postgresql com_banners Language & Strings Installation |
| Labels |
Added:
?
?
|
||
brianteeman
- comment
- 17 Nov 2019
Not really
Quy
- comment
- 17 Nov 2019
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27095.
SharkyKZ
- comment
- 18 Nov 2019
@brianteeman Can you also update com_banners.banner record in #__content_types table?
brianteeman
- comment
- 18 Nov 2019
do you mean in the field_mappings?
SharkyKZ
- comment
- 18 Nov 2019
Yes.
brianteeman
- comment
- 28 Nov 2019
argue amongst yourselves - I can't be bothered
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-11-28 19:03:24 |
| Closed_By | ⇒ | brianteeman |
richard67
- comment
- 28 Nov 2019
Yes, ignorance is one of your key competences.
Sorry, that was not fair. Was too upset, calmed down.
Category alias can be removed too.