User tests: Successful: Unsuccessful:
As the component menu is now used for components that create some form of site content this Pr moves the private messages component from the Component menu to the users menu.
When testing simply applying the patch will only add the messages menu items to the users menu. It will not remove it from the component menu. As the sql change is data and not structure you cannot use the database fix either. It will have to be a direct update in the sql using phpmyadmin or similar
Status | New | ⇒ | Pending |
Category | ⇒ | SQL Administration com_admin Postgresql com_menus Language & Strings Installation |
@SniperSister @zero-24 could you look at rips please
hmm drone seams to fail on system-tests-mysql not rips: https://ci.joomla.org/joomla/joomla-cms/26172 ;)
Labels |
Added:
?
?
|
This was the failure https://ci.joomla.org/joomla/joomla-cms/26146 @zero-24
Was an false positive it is passing now.
Conflicts resolved
Updated branch to kickstart drone
I have tested this item
New messaging menu items appear in the users menu and function as expected. As mentioned, it is also still located in components.
I have tested this item
New messaging menu items appear in the users menu and function as expected. As mentioned, it is also still located in components.
I have tested this item
I have tested this item
Looks like the change is not done for the alternate preset
Until a decision is made #27096 (comment) I am not wasting my time
I will now leave contributing to joomla 4 until it is clear what is happening with the other template. If that proceeds the way that they want then any change here is a complete waste of all of our time
@brianteeman , i to understand what is unclear. The read-me for Khonsu is perfectly clear and has been discussed also with you.
The Khonsu community initiative is intended to be an alternate/alternative template, J4 is NOT waiting for Khonsu, Khonsu will have to live up to the same standards as other contributions. If and only if all these requirements are met it will be considered.
@marcodings I know we have discussed it before and I know you have stated that before. But I guess you need to tell the people on the Khonsu repository that then. They are definitely still of the opinion that they are building a replacement template.
See joomla-projects/j4adminui#184 (comment)
Well, Joomla should not have any alternative admin templates. I talked to Marco on this few days back. We have to make our mind fixed. Choose Atum or Khonsu but not both. As an extension developer, I can guarantee you that multiple templates will ruin everything.
Keeping backward compatibility with Atum has nothing to do with the requirements. Atum is not a standard.
Looks like the change is not done for the alternate preset
@infograf768
I really don't understand that code. Can you either do a pr to my branch for that or create a separate PR just for that
I really don't understand that code. Can you either do a pr to my branch for that or create a separate PR just for that.
Can do a PR after this one is merged.
Or you can use this .diff in your PR
Thanks @infograf768 I have applied your patch
I have tested this item
I will try to get the conflicts resolved tonight
@brianteeman , i to understand what is unclear. The read-me for Khonsu is perfectly clear and has been discussed also with you.
Guess that wasn't the case after all. ;)
@richard67 if you are able to help resolving the conflicts with the sql I would appreciate it. I always mess up on this part.
@brianteeman Tonight after work I can have a look on it if nobody else was faster.
@richard67 greatly appreciated
@brianteeman Am on it, stay tuned.
@brianteeman Please check brianteeman#95, especially the instructions in description, and let me know if you have questions. Btw. is there a way to contact you elsewhere, e.g. on Glip, in case if we have to solve things together and discussion on GH would be uncomfortable?
Update: Note that my PR doesn't correct yet the lft and rgt values in the menu table, see description there.
@brianteeman It looks as if lft and rgt were messed up even before. Am just looking and working on fixing them.
Update: With "messed up before" I mean the 4.0-dev branch, not your PR as it was before my changes.
@brianteeman I have it, lft and rgt, will make PR for you in a bit, stay tuned. Am doing it in the manual way, like learned on German Joomla Day last year.
@brianteeman Delet statements from update SQL script executed in PhpMyAdmin don't delete the old records. Must be something wrong with the where clause. Am checking.
@brianteeman It is the 'index.php?' missing at the beginning of the link in the where clause of the update sql script which makes deletion fail.
oops
I have tested this item
Tested new install and statements from update sql scripts on MySQL and PostgreSQL. Tested applying the patch on MySQL.
I have tested this item
Status | Pending | ⇒ | Ready to Commit |
RTC
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-02-06 08:17:44 |
Closed_By | ⇒ | rdeutz | |
Labels |
Added:
?
|
thanks all
Add module to the Users Dashboard.