? ? ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
17 Nov 2019

As the component menu is now used for components that create some form of site content this Pr moves the private messages component from the Component menu to the users menu.

When testing simply applying the patch will only add the messages menu items to the users menu. It will not remove it from the component menu. As the sql change is data and not structure you cannot use the database fix either. It will have to be a direct update in the sql using phpmyadmin or similar

avatar brianteeman brianteeman - open - 17 Nov 2019
avatar brianteeman brianteeman - change - 17 Nov 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 17 Nov 2019
Category SQL Administration com_admin Postgresql com_menus Language & Strings Installation
avatar Quy
Quy - comment - 17 Nov 2019

Add module to the Users Dashboard.

27096

avatar brianteeman
brianteeman - comment - 17 Nov 2019

@Quy that is beyond the scope of this PR as it doesn't currently exist and there are other things missing from the dashboard

avatar brianteeman
brianteeman - comment - 17 Nov 2019

@SniperSister @zero-24 could you look at rips please

avatar zero-24
zero-24 - comment - 18 Nov 2019

hmm drone seams to fail on system-tests-mysql not rips: https://ci.joomla.org/joomla/joomla-cms/26172 ;)

avatar zero-24 zero-24 - change - 18 Nov 2019
Labels Added: ? ?
avatar brianteeman
brianteeman - comment - 18 Nov 2019
avatar zero-24
zero-24 - comment - 18 Nov 2019

Was an false positive it is passing now.

avatar brianteeman
brianteeman - comment - 30 Nov 2019

Conflicts resolved

avatar brianteeman
brianteeman - comment - 11 Dec 2019

Updated branch to kickstart drone

avatar jwaisner jwaisner - test_item - 4 Jan 2020 - Tested successfully
avatar jwaisner
jwaisner - comment - 4 Jan 2020

I have tested this item successfully on ec0c573

New messaging menu items appear in the users menu and function as expected. As mentioned, it is also still located in components.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27096.

avatar jwaisner
jwaisner - comment - 4 Jan 2020

I have tested this item successfully on ec0c573

New messaging menu items appear in the users menu and function as expected. As mentioned, it is also still located in components.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27096.

avatar jwaisner jwaisner - test_item - 4 Jan 2020 - Tested successfully
avatar jwaisner
jwaisner - comment - 4 Jan 2020

I have tested this item successfully on cc6474d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27096.

avatar brianteeman
brianteeman - comment - 5 Jan 2020

I have committed your changes @Quy

I will now leave contributing to joomla 4 until it is clear what is happening with the other template. If that proceeds the way that they want then any change here is a complete waste of all of our time

avatar jwaisner jwaisner - test_item - 6 Jan 2020 - Tested successfully
avatar jwaisner
jwaisner - comment - 6 Jan 2020

I have tested this item successfully on 8084ec7


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27096.

avatar infograf768
infograf768 - comment - 6 Jan 2020

Looks like the change is not done for the alternate preset

avatar brianteeman
brianteeman - comment - 6 Jan 2020

Until a decision is made #27096 (comment) I am not wasting my time

avatar marcodings
marcodings - comment - 6 Jan 2020

I will now leave contributing to joomla 4 until it is clear what is happening with the other template. If that proceeds the way that they want then any change here is a complete waste of all of our time

@brianteeman , i to understand what is unclear. The read-me for Khonsu is perfectly clear and has been discussed also with you.

The Khonsu community initiative is intended to be an alternate/alternative template, J4 is NOT waiting for Khonsu, Khonsu will have to live up to the same standards as other contributions. If and only if all these requirements are met it will be considered.

avatar brianteeman
brianteeman - comment - 6 Jan 2020

@marcodings I know we have discussed it before and I know you have stated that before. But I guess you need to tell the people on the Khonsu repository that then. They are definitely still of the opinion that they are building a replacement template.

See joomla-projects/j4adminui#184 (comment)

Well, Joomla should not have any alternative admin templates. I talked to Marco on this few days back. We have to make our mind fixed. Choose Atum or Khonsu but not both. As an extension developer, I can guarantee you that multiple templates will ruin everything.

Keeping backward compatibility with Atum has nothing to do with the requirements. Atum is not a standard.

avatar brianteeman
brianteeman - comment - 6 Jan 2020

Looks like the change is not done for the alternate preset
@infograf768

I really don't understand that code. Can you either do a pr to my branch for that or create a separate PR just for that

avatar infograf768
infograf768 - comment - 7 Jan 2020

@brianteeman

I really don't understand that code. Can you either do a pr to my branch for that or create a separate PR just for that.

Can do a PR after this one is merged.

avatar infograf768
infograf768 - comment - 7 Jan 2020

Or you can use this .diff in your PR

messaging.diff.zip

avatar brianteeman
brianteeman - comment - 7 Jan 2020

Thanks @infograf768 I have applied your patch

avatar jwaisner jwaisner - test_item - 7 Jan 2020 - Tested successfully
avatar jwaisner
jwaisner - comment - 7 Jan 2020

I have tested this item successfully on 85e1758


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27096.

avatar brianteeman
brianteeman - comment - 3 Feb 2020

I will try to get the conflicts resolved tonight

@brianteeman , i to understand what is unclear. The read-me for Khonsu is perfectly clear and has been discussed also with you.

Guess that wasn't the case after all. ;)

avatar brianteeman
brianteeman - comment - 4 Feb 2020

@richard67 if you are able to help resolving the conflicts with the sql I would appreciate it. I always mess up on this part.

avatar richard67
richard67 - comment - 4 Feb 2020

@brianteeman Tonight after work I can have a look on it if nobody else was faster.

avatar brianteeman
brianteeman - comment - 4 Feb 2020

@richard67 greatly appreciated

avatar richard67
richard67 - comment - 4 Feb 2020

@brianteeman Am on it, stay tuned.

avatar richard67
richard67 - comment - 4 Feb 2020

@brianteeman Please check brianteeman#95, especially the instructions in description, and let me know if you have questions. Btw. is there a way to contact you elsewhere, e.g. on Glip, in case if we have to solve things together and discussion on GH would be uncomfortable?

Update: Note that my PR doesn't correct yet the lft and rgt values in the menu table, see description there.

avatar richard67
richard67 - comment - 4 Feb 2020

@brianteeman It looks as if lft and rgt were messed up even before. Am just looking and working on fixing them.

Update: With "messed up before" I mean the 4.0-dev branch, not your PR as it was before my changes.

avatar richard67
richard67 - comment - 4 Feb 2020

@brianteeman I have it, lft and rgt, will make PR for you in a bit, stay tuned. Am doing it in the manual way, like learned on German Joomla Day last year.

avatar richard67
richard67 - comment - 4 Feb 2020

@brianteeman Delet statements from update SQL script executed in PhpMyAdmin don't delete the old records. Must be something wrong with the where clause. Am checking.

avatar richard67
richard67 - comment - 4 Feb 2020

@brianteeman It is the 'index.php?' missing at the beginning of the link in the where clause of the update sql script which makes deletion fail.

avatar brianteeman
brianteeman - comment - 4 Feb 2020

oops

avatar richard67 richard67 - test_item - 4 Feb 2020 - Tested successfully
avatar richard67
richard67 - comment - 4 Feb 2020

I have tested this item successfully on f2a3ccf


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27096.

avatar richard67
richard67 - comment - 4 Feb 2020

Tested new install and statements from update sql scripts on MySQL and PostgreSQL. Tested applying the patch on MySQL.

avatar jwaisner jwaisner - test_item - 5 Feb 2020 - Tested successfully
avatar jwaisner
jwaisner - comment - 5 Feb 2020

I have tested this item successfully on f2a3ccf


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27096.

avatar richard67 richard67 - change - 5 Feb 2020
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 5 Feb 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27096.

avatar rdeutz rdeutz - change - 6 Feb 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-02-06 08:17:44
Closed_By rdeutz
Labels Added: ?
avatar rdeutz rdeutz - close - 6 Feb 2020
avatar rdeutz rdeutz - merge - 6 Feb 2020
avatar brianteeman
brianteeman - comment - 6 Feb 2020

thanks all

Add a Comment

Login with GitHub to post a comment