[#27092] - [4.0] Deletes some specific cpanel strings for help and system presets and creates mod_menu strings with same value
- Closed
- 25 Nov 2019
- Medium
- Build: 4.0-dev
- # 27092
- Diff
- infograf768:4.0_untranslated_cpanel_strings
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #27072
Summary of Changes
As title says.
When a system or help preset is placed in the sidebar menu position, whether in an Administrator Menu Module (or an Administrator Dashboard Module which is not advised as we would have a bad display) , and the page loaded is Cpanel, no problem.
But when we switch page for example to Articles Manager, the titles of these presets are not loaded and therefore untranslated.
To solve the issue this PR changes the strings to mod_menu strings and corrects presets
Testing Instructions
Create system and help presets Administrator Menu modules and place them in menu position.
Before patch
COM_CPANEL_DASHBOARD_HELP_FIND_HELP="Find Help"
COM_CPANEL_DASHBOARD_HELP_GET_INVOLVED="Get Involved"
COM_CPANEL_DASHBOARD_HELP_MEET_JOOMLERS="Meet Joomlers"
COM_CPANEL_DASHBOARD_HELP_NEWS="News"
COM_CPANEL_DASHBOARD_HELP_RESOURCES="Resources"
COM_CPANEL_SYSTEM_SETUP="Setup"
are untranslated See #27072
After patch
All is fine
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Modules Administration |
You are correct. This happens when no default or alternate menu is also published in menu position.
Would be totally idiotic to do that but, nevertheless, looking into it
| Labels |
Added:
?
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27092.
Or maybe the preset should not be using com_cpanel strings?
Or maybe the preset should not be using com_cpanel strings?
Only other way would be to add them to en-GB.ini
More confusing imho. Let's keep the load, but out of the loop. Just waiting for Michael response.
Note: I also found some issue with lang overrides for dashboard.
Or add them to mod_menu language file so it uses its own strings like it should.
Or add them to mod_menu language file so it uses its own strings like it should.
I guess this is the best solution. On it.
| Category | Modules Administration | ⇒ | Administration com_menus Language & Strings |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27092.
| Labels |
Added:
?
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27092.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27092.
| Labels |
Added:
?
|
||
As the PR has changed since the first post could you please update the title and description
| Title |
|
||||||
Thank
@infograf768 can you fix conflicts here please
Sorry, can't fix conflicts on this branch.
I have to make a new PR.
| Category | Administration com_menus Language & Strings | ⇒ | Unit Tests Repository Administration com_config com_content com_csp com_fields com_finder com_joomlaupdate com_languages com_media com_menus com_messages com_modules com_redirect com_templates |
Closing
| Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-11-25 08:56:39 |
| Closed_By | ⇒ | infograf768 | |
| Labels |
Added:
?
Removed: ? |
||
Still untranslated with Help.