Feeling Lucky
?
[#27091] - [4.0] Fix exporting banner tracks
- Closed
- 24 Nov 2019
- Medium
- Build: 4.0-dev
- # 27091
- Diff
- Quy:26818-export
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_banners Layout |
vijaykhollam
- comment
- 20 Nov 2019
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27091.
| Status | Pending | ⇒ | Ready to Commit |
Quy
- comment
- 20 Nov 2019
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27091.
Quy
- comment
- 20 Nov 2019
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27091.
| Labels |
Added:
?
|
||
wilsonge
- comment
- 24 Nov 2019
I think a variation of the fix in the original PR #26848 is actually correct (we'd need to change the jQuery dependency to use native JS which should be easy enough).
Reason being is whilst this works (it's effectively reversing #10934 ) - effectively all this does is mask we've had a b/c break in the layout - the layout when used by other extensions is still going to have exactly the same issues as originally.
If we do go down this route we basically have to remove the toolbar modal layout - as it's going to be useless
| Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-11-24 20:33:44 |
| Closed_By | ⇒ | Quy |
I have tested this item✅ successfully on d1fc672
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27091.