? Pending

User tests: Successful: Unsuccessful:

avatar Quy
Quy
16 Nov 2019

Pull Request for Issue #17931.

Summary of Changes

Use right property.

Testing Instructions

Uninstall an extension on Joomla 4

Expected result

The script file is executed and the function 'uninstall' is called inside the class com_xxxxInstallerScript, when the function 'uninstall' is called it's still possible to use JText::_('...'); loading language files included under the component folder such as:
Joomla40/administrator/components/com_xxx/language/en-GB/en-GB.com_xxx.ini

Actual result

Files are already deleted at this stage compared to the current Joomla 3 and Joomla 2.5
Thus the JText won't translate strings anymore because it's no more possible to load language files already deleted. It works only if the component was using language files under:
Joomla40/administrator/language/en-GB/en-GB.com_xxx.ini

avatar Quy Quy - open - 16 Nov 2019
avatar Quy Quy - change - 16 Nov 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 16 Nov 2019
Category Libraries
avatar infograf768
infograf768 - comment - 21 Dec 2019

Looks fine on review. As I have no component to test, please @joeforjoomla test the patch.

avatar wilsonge wilsonge - change - 1 Apr 2020
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-04-01 18:21:28
Closed_By wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 1 Apr 2020
avatar wilsonge wilsonge - merge - 1 Apr 2020
avatar wilsonge
wilsonge - comment - 1 Apr 2020

Thanks!

Add a Comment

Login with GitHub to post a comment