[#27089] - [4.0] Replace "hidden" class with "d-none"
- Closed
- 19 Nov 2019
- Medium
- Build: 4.0-dev
- # 27089
- Diff
- C-Lodder:patch-2
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
Simple change is classes. Both do exactly the same.
Not sure why there is a duplicate class that does exactly the same and also has a pointless visibility: hidden; when display:none will supersede and replace the allocated space.
Testing Instructions
Code review
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_modules |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27089.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27089.
If this change is to be accepted shouldn't the other instances of class="hidden also be changed?
This class is used by JS here https://github.com/joomla/joomla-cms/blob/cb00087348ce1a3a7546ed8c5fca37a2af94cd6b/build/media_source/com_cpanel/js/admin-add_module.es6.js.
Not sure how to test this, but removing the class probably breaks something.
Ah didn't see that
| Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-11-19 17:32:05 |
| Closed_By | ⇒ | C-Lodder | |
| Labels |
Added:
?
?
|
||
I have tested this item✅ successfully on 2e9bd27
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27089.