Feeling Lucky
?
?
?
?
[#26073] - [4.0] Adding error handling for installer
- Closed
- 30 Nov 2019
- Medium
- Build: 4.0-dev
- # 26073
- Diff
- Hackwar:j4installerrors
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
When the ajax requests during installation are failing, we currently get no feedback about that in the UI. This PR adds some error handling for that. This is not perfect, but better than nothing and maybe someone can help make this better.
Testinstructions
- Modify /installation/src/Controller/InstallationController.php and add
echo 'something';at line 74 (This breaks the response and triggers the error) - Go through the installation and fill everything, then click on
Install Joomla - See the loadinglayer show quickly and then disappear again and at the top of the page you get an error message.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Installation Language & Strings JavaScript |
| Labels |
Added:
?
?
|
||
rmittl
- comment
- 19 Oct 2019
Tested successfully
Error message appears.
| Status | Pending | ⇒ | Ready to Commit |
Quy
- comment
- 21 Oct 2019
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26073.
| Labels |
Added:
?
|
||
wilsonge
- comment
- 31 Oct 2019
Kinda unconvinced by blatting out the raw code from an end user perspective. Can we not just give that message without appending the text and console.error the raw response which would be enough for us to see it in system tests
wilsonge
- comment
- 30 Nov 2019
I've pushed a modified version of this with the changes I requested above
| Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-11-30 22:10:10 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
I have tested this item✅ successfully on 725af51
Appled patch
changed /installation/src/Controller/InstallationController.php
installed joomla
-> error message appear
work as descriped
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26073.