? ? Pending

User tests: Successful: Unsuccessful:

avatar dryabov
dryabov
29 Aug 2019

Summary of Changes

Joomla\CMS\Application\AdministratorApplication::findOption method changes value of option to com_login for expired sessions, but it keeps other query params. That's why controller should be reset there to avoid "Invalid controller class: ..." error message displayed in the case of such a findOption-redirecting from actual extension page with specified controller in the URL.

Testing Instructions

In the /administrator area, open any 3rdparty extension page with specified controller parameter in the URL and clear cookies (or wait for session cookie expiration), and then refresh the page.

Expected result

Login form is displayed.

Actual result

"Invalid controller class: ..." message is displayed.

Comments

Core components are not affected as they are not use multiple display controllers.

avatar dryabov dryabov - open - 29 Aug 2019
avatar dryabov dryabov - change - 29 Aug 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 29 Aug 2019
Category Administration com_login
avatar franz-wohlkoenig franz-wohlkoenig - change - 30 Aug 2019
Title
Reset controller name in administrator's com_login
[4.0] Reset controller name in administrator's com_login
avatar franz-wohlkoenig franz-wohlkoenig - edited - 30 Aug 2019
avatar vaibhavsTekdi vaibhavsTekdi - test_item - 19 Oct 2019 - Tested successfully
avatar vaibhavsTekdi
vaibhavsTekdi - comment - 19 Oct 2019

I have tested this item successfully on 0d32f69


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26072.

avatar pallaviu pallaviu - test_item - 19 Oct 2019 - Tested successfully
avatar pallaviu
pallaviu - comment - 19 Oct 2019

I have tested this item successfully on 0d32f69


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26072.

avatar Quy Quy - change - 19 Oct 2019
Status Pending Ready to Commit
avatar Quy
Quy - comment - 19 Oct 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26072.

avatar wilsonge wilsonge - change - 25 Oct 2019
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-10-25 22:19:44
Closed_By wilsonge
Labels Added: ? ?
avatar wilsonge wilsonge - close - 25 Oct 2019
avatar wilsonge wilsonge - merge - 25 Oct 2019
avatar wilsonge
wilsonge - comment - 25 Oct 2019

Thanks for your first PR to Joomla. Thanks!

Add a Comment

Login with GitHub to post a comment