? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
29 Aug 2019

I made a copy paste error in #20962 and changed the date column from created date to published date. This PR reverts that

testing

create a new article and leave it in the default unpublished
check it in the module on the home dashboard and the date will be messed up as it doesnt have a date
check in the module on the home dashboard and the date will be today.
now go back to the article and change the created date to yesterday
check in the module on the home dashboard and the date will still be today.
this is because when the published date is not set the helper uses today as the value (which is a recent change and why people couldnt replicate the issue)

apply pr -
check in the module on the home dashboard and the date will correctly be yesterday.

Votes

# of Users Experiencing Issue
0/1
Average Importance Score
3.00

avatar brianteeman brianteeman - open - 29 Aug 2019
avatar brianteeman brianteeman - change - 29 Aug 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 29 Aug 2019
Category Modules Administration
avatar Quy Quy - test_item - 31 Aug 2019 - Tested successfully
avatar Quy
Quy - comment - 17 Oct 2019

This is no longer reproducible.

avatar idefax
idefax - comment - 19 Oct 2019

I can't reproduce it.

Tested with:

PHP Version 7.3.8
Web Server Apache
WebServer to PHP Interface cgi-fcgi
Joomla! Version Joomla! 4.0.0-beta1-dev Development [ Amani ] 17-October-2019 20:21 GMT
User Agent Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:69.0) Gecko/20100101 Firefox/69.0


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26074.

avatar neotrendch
neotrendch - comment - 19 Oct 2019

not reproducible


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26074.

avatar oschuldt oschuldt - test_item - 19 Oct 2019 - Tested successfully
avatar oschuldt
oschuldt - comment - 19 Oct 2019

I have tested this item successfully on b5d857b

ok


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26074.

avatar pravinTek
pravinTek - comment - 19 Oct 2019

Unable to reproduce and it's showing publish date

avatar Nilesh5995 Nilesh5995 - test_item - 19 Oct 2019 - Tested successfully
avatar Nilesh5995
Nilesh5995 - comment - 19 Oct 2019

I have tested this item successfully on b5d857b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26074.

avatar MarLinDT
MarLinDT - comment - 19 Oct 2019

not reproducible


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26074.

avatar brianteeman
brianteeman - comment - 19 Oct 2019

The error with the date format has indeed gone now but it is still displaying the wrong date

avatar idefax
idefax - comment - 19 Oct 2019

Date looks good to me. "Beitrag 1" without patch, "Beitrag 2" with patch.

Screenshot


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26074.

avatar Quy
Quy - comment - 20 Oct 2019

Make same change to mod_popular.

avatar vijaykhollam
vijaykhollam - comment - 2 Nov 2019

The date looks good to me without applying the patch.
#pbf19 #test1


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26074.
avatar Quiviro
Quiviro - comment - 15 Nov 2019

All seems correct before patch. After applying it, nothing changes?
#PBF19es


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26074.

avatar Quiviro Quiviro - test_item - 15 Nov 2019 - Tested unsuccessfully
avatar Quiviro
Quiviro - comment - 15 Nov 2019

I have tested this item ? unsuccessfully on b5d857b

Nothing seems to change after applying the patch


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26074.

avatar brianteeman brianteeman - change - 30 Nov 2019
Labels Added: ?
avatar jwaisner
jwaisner - comment - 5 Jan 2020

I also cannot reproduce this issue. When checking the dashboard the date is correct for the new article.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26074.

avatar jwaisner
jwaisner - comment - 5 Jan 2020

I also cannot reproduce this issue. When checking the dashboard the date is correct for the new article.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26074.

avatar Fedik Fedik - test_item - 20 Jan 2020 - Tested successfully
avatar Fedik
Fedik - comment - 20 Jan 2020

I have tested this item successfully on cff4675


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26074.

avatar Fedik
Fedik - comment - 20 Jan 2020

It obviously should be $item->created instead of $item->publish_up,

For testers: just apply the patch and make sure the date are displayed without any errors

avatar SharkyKZ
SharkyKZ - comment - 26 Jan 2020

This looks misleading when ordering by modified date. When using automatic title, the title is Last 5 Modified Articles but created date is shown. Maybe change this to be based on ordering?

avatar brianteeman
brianteeman - comment - 12 Feb 2020

@SharkyKZ automatic title is a separate issue

avatar brianteeman
brianteeman - comment - 12 Feb 2020

updated original post and instructions

avatar brianteeman brianteeman - change - 12 Feb 2020
The description was changed
avatar brianteeman brianteeman - edited - 12 Feb 2020
avatar SharkyKZ
SharkyKZ - comment - 13 Feb 2020

It's not just with automatic title. You can title the module "Recently Modified Articles" yourself and order by modified date. But created date is shown instead. I think that's wrong. At the very least date label should indicate which date is shown.

avatar wilsonge wilsonge - change - 10 Apr 2020
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-04-10 23:06:42
Closed_By wilsonge
avatar wilsonge wilsonge - close - 10 Apr 2020
avatar wilsonge wilsonge - merge - 10 Apr 2020
avatar wilsonge
wilsonge - comment - 10 Apr 2020

Merging this on review based on what the original PR did. Don't dispute something looks wrong with the existing 3.x behaviour though - so if someone wants to work on that I'd definitely be interested in such a PR

avatar brianteeman
brianteeman - comment - 10 Apr 2020

thx

Add a Comment

Login with GitHub to post a comment