User tests: Successful: Unsuccessful:
I made a copy paste error in #20962 and changed the date column from created date to published date. This PR reverts that
create a new article and leave it in the default unpublished
check it in the module on the home dashboard and the date will be messed up as it doesnt have a date
check in the module on the home dashboard and the date will be today.
now go back to the article and change the created date to yesterday
check in the module on the home dashboard and the date will still be today.
this is because when the published date is not set the helper uses today as the value (which is a recent change and why people couldnt replicate the issue)
apply pr -
check in the module on the home dashboard and the date will correctly be yesterday.
Status | New | ⇒ | Pending |
Category | ⇒ | Modules Administration |
I can't reproduce it.
Tested with:
PHP Version 7.3.8
Web Server Apache
WebServer to PHP Interface cgi-fcgi
Joomla! Version Joomla! 4.0.0-beta1-dev Development [ Amani ] 17-October-2019 20:21 GMT
User Agent Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:69.0) Gecko/20100101 Firefox/69.0
not reproducible
I have tested this item
ok
Unable to reproduce and it's showing publish date
I have tested this item
not reproducible
The error with the date format has indeed gone now but it is still displaying the wrong date
Date looks good to me. "Beitrag 1" without patch, "Beitrag 2" with patch.
Make same change to mod_popular.
The date looks good to me without applying the patch.
#pbf19 #test1
All seems correct before patch. After applying it, nothing changes?
#PBF19es
I have tested this item
Nothing seems to change after applying the patch
Labels |
Added:
?
|
I also cannot reproduce this issue. When checking the dashboard the date is correct for the new article.
I also cannot reproduce this issue. When checking the dashboard the date is correct for the new article.
I have tested this item
It obviously should be $item->created
instead of $item->publish_up
,
For testers: just apply the patch and make sure the date are displayed without any errors
This looks misleading when ordering by modified date. When using automatic title, the title is Last 5 Modified Articles
but created date is shown. Maybe change this to be based on ordering?
updated original post and instructions
It's not just with automatic title. You can title the module "Recently Modified Articles" yourself and order by modified date. But created date is shown instead. I think that's wrong. At the very least date label should indicate which date is shown.
Status | Pending | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-04-10 23:06:42 |
Closed_By | ⇒ | wilsonge |
Merging this on review based on what the original PR did. Don't dispute something looks wrong with the existing 3.x behaviour though - so if someone wants to work on that I'd definitely be interested in such a PR
thx
This is no longer reproducible.