? ?
avatar coolcat-creations
coolcat-creations
29 Aug 2019

The button styling has to be fixed but can't be done because the Button code is not consistent. Please see PR #26070
for reference.

avatar coolcat-creations coolcat-creations - open - 29 Aug 2019
avatar joomla-cms-bot joomla-cms-bot - change - 29 Aug 2019
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 29 Aug 2019
avatar brianteeman
brianteeman - comment - 29 Aug 2019

Please post the buttons that you say have problems

avatar Hackwar
Hackwar - comment - 29 Aug 2019

Sorry, but that is a completely useless bug report. If I hadn't read the other PR, I wouldn't know what you were talking about. And even now I have no idea what you mean with the apparently broken buttons, because they are pretty much okay as far as I can see.

avatar coolcat-creations
coolcat-creations - comment - 29 Aug 2019

grafik

avatar coolcat-creations
coolcat-creations - comment - 29 Aug 2019

grafik

avatar coolcat-creations
coolcat-creations - comment - 29 Aug 2019

grafik
Quickicons using different classes too

avatar coolcat-creations
coolcat-creations - comment - 29 Aug 2019

grafik
Dropdown in Manage Menus also different code than save and close button

avatar coolcat-creations
coolcat-creations - comment - 29 Aug 2019

Export Icon does not use class btn-sm
grafik

avatar coolcat-creations
coolcat-creations - comment - 29 Aug 2019

Option and Help does not use btn-sm
grafik

avatar coolcat-creations
coolcat-creations - comment - 29 Aug 2019

Batch does not use btn-sm class
grafik

avatar coolcat-creations
coolcat-creations - comment - 29 Aug 2019

Install Buttons Icon missing:
grafik

avatar coolcat-creations
coolcat-creations - comment - 29 Aug 2019

Do not have btn-sm class
grafik

avatar coolcat-creations
coolcat-creations - comment - 29 Aug 2019

left one does not use btn-sm class
grafik

avatar Hackwar
Hackwar - comment - 29 Aug 2019

grafik

Again, can you please elaborate what is wrong with the markup that apparently makes this wrong?

avatar coolcat-creations
coolcat-creations - comment - 29 Aug 2019

grafik

If the code structure is the same, then all the dropdown-buttons will appear the same. I don't think we should fix wrong classes or different used structures with css. The structure should be likewise for same kind of buttons.

For the btn-sm classes I hope it's clear - there has to be a decision if there should be big OR small buttons and the classes should be equal. For the Action Drop Down / Save and Close both should use the same structure and then we can style one of these, but it should be consistent codewise.

avatar Hackwar
Hackwar - comment - 29 Aug 2019

Sorry, I might be blind, but I don't see a difference between these. It is the same XML structure...

avatar coolcat-creations
coolcat-creations - comment - 29 Aug 2019

It's not the same structure, if it was so it would appear the same. At the bottom you can spot the differences.

avatar coolcat-creations
coolcat-creations - comment - 29 Aug 2019

This is how it looks like if the structure is the same like save&close:
grafik

avatar coolcat-creations
coolcat-creations - comment - 29 Aug 2019

Wrong styling here too...
grafik

avatar brianteeman
brianteeman - comment - 29 Aug 2019

what is wrong with that?

avatar franz-wohlkoenig franz-wohlkoenig - change - 30 Aug 2019
Labels Added: ?
avatar franz-wohlkoenig franz-wohlkoenig - labeled - 30 Aug 2019
avatar coolcat-creations
coolcat-creations - comment - 30 Aug 2019

It's again different styling, markup and size.

avatar brianteeman
brianteeman - comment - 30 Aug 2019

seems ok to me

avatar franz-wohlkoenig franz-wohlkoenig - change - 31 Aug 2019
Status New Discussion
avatar brianteeman
brianteeman - comment - 11 Apr 2020

Is there anything to do here or should it be closed

avatar coolcat-creations
coolcat-creations - comment - 12 Apr 2020

The Toolbar Buttons seem to have almost all now a consistent class btn-sm - but in my opinion the toolbar buttons represent a regular size. So the Class should be not btn-sm
If you compare to the Install Buttons on the Home dashboard, the Install buttons are way smaller. They also have the btn-sm class. Which is correct for the small ones.

btn-sm
grafik

should not be btn-sm
grafik

should have the same class as the toolbar Buttons:
grafik

avatar brianteeman
brianteeman - comment - 25 Apr 2020

Closed as there is a pr

avatar brianteeman brianteeman - close - 25 Apr 2020
avatar brianteeman brianteeman - change - 25 Apr 2020
Status Discussion Closed
Closed_Date 0000-00-00 00:00:00 2020-04-25 12:48:07
Closed_By brianteeman

Add a Comment

Login with GitHub to post a comment