Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#25420] - [4.0] Nested Bootstrap tabs

NPM Resource Changed ? ? Pending

User tests: Successful: Unsuccessful:

avatar SharkyKZ
SharkyKZ
4 Jul 2019

Pull Request for Issue #20627.

Summary of Changes

Fixes nested Bootstrap tabs

Testing Instructions

Create a nested Bootstrap tab set:

echo JHtml::_('bootstrap.startTabSet', 'outerTab', array('active' => 'x1'));

echo JHtml::_('bootstrap.addTab', 'outerTab', 'x1', 'x1');
echo 'Outer Tab 1';
echo JHtml::_('bootstrap.endTab');

echo JHtml::_('bootstrap.addTab', 'outerTab', 'x2', 'x2');
echo 'Outer Tab 2';

// Nested tabset
echo JHtml::_('bootstrap.startTabSet', 'innerTab', array('active' => 'y1'));

echo JHtml::_('bootstrap.addTab', 'innerTab', 'y1', 'y1');
echo 'Inner Tab 1';
echo JHtml::_('bootstrap.endTab');

echo JHtml::_('bootstrap.addTab', 'innerTab', 'y2', 'y2');
echo 'Inner Tab 2';
echo JHtml::_('bootstrap.endTab');

echo JHtml::_('bootstrap.endTabSet');
// End of nested tabset

echo JHtml::_('bootstrap.endTab');
echo JHtml::_('bootstrap.endTabSet');

Expected result

Tabs working normally:

Actual result

Nested tabs shown along with top most level tabs:

Documentation Changes Required

No.

Votes

# of Users Experiencing Issue
1/1
Average Importance Score
5.00
avatar SharkyKZ SharkyKZ - open - 4 Jul 2019
avatar SharkyKZ SharkyKZ - change - 4 Jul 2019
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 4 Jul 2019
Category ⇒ JavaScript Repository NPM Change
avatar SharkyKZ SharkyKZ - change - 4 Jul 2019
Labels Added: NPM Resource Changed ?
avatar manojLondhe manojLondhe - test_item - 4 Jul 2019 - Tested unsuccessfully
avatar manojLondhe
manojLondhe - comment - 4 Jul 2019

I have tested this item ? unsuccessfully on ff97a1f

This is what I see after applying this patch
screen shot 2019-07-04 at 12 58 07

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25420.

avatar manojLondhe manojLondhe - test_item - 4 Jul 2019 - Tested successfully
avatar manojLondhe
manojLondhe - comment - 4 Jul 2019

I have tested this item ✅ successfully on ff97a1f

Sorry! My bad.

Working after npm install (rebuilding JS files)

screen shot 2019-07-04 at 13 07 22

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25420.

avatar manojLondhe
manojLondhe - comment - 4 Jul 2019

I have tested this item ✅ successfully on ff97a1f

Sorry! My bad.

Working after npm install (rebuilding JS files)

screen shot 2019-07-04 at 13 07 22

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25420.

avatar Quy Quy - test_item - 4 Jul 2019 - Tested successfully
avatar Quy
Quy - comment - 4 Jul 2019

I have tested this item ✅ successfully on ff97a1f

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25420.

avatar Quy Quy - change - 4 Jul 2019
Status Pending ⇒ Ready to Commit
avatar Quy
Quy - comment - 4 Jul 2019

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25420.

avatar wilsonge wilsonge - change - 5 Jul 2019
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2019-07-05 14:00:58
Closed_By ⇒ wilsonge
Labels Added: ?
avatar wilsonge
wilsonge - comment - 5 Jul 2019

Thanks!

Add a Comment

Login with GitHub to post a comment