[#25419] - [4.0] remove individual credits from templates
- Fixed in Code Base
- 4 Jul 2019
- Medium
- Build: 4.0-dev
- # 25419
- Diff
- alikon:patch-119
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #25237 .
Summary of Changes
removed the individual credits from templates manifest, i.e the author tag now is:
<author>Joomla! Project</author>
like all over the core code
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Templates (admin) Front End Templates (site) |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25419.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25419.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25419.
We have done this before in Joomla https://github.com/joomla/joomla-cms/blob/staging/administrator/templates/hathor/templateDetails.xml#L6 j3 (and 2.5) and j1.5 https://github.com/gdimi/Joomla1.5.X/blob/master/administrator/templates/khepri/templateDetails.xml#L6 so for whatever reason we seem to have always treated templates different
so what's the point ? we should continue to do it ?...
then we should give credits in the <author> tag to every pr author if we follow this approach, why have 2nd class contributor ?
The reason it was done before was explained by @ot2sen #25237 (comment) That definitely is not a valid reason to do it now.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-07-04 09:54:40 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
?
|
||
Thank you very much
I have tested this item✅ successfully on 59a2c7e
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25419.