User tests: Successful: Unsuccessful:
When changing the permission of something if there is a child group then a popup notice is displayed. For a sighted user they can still carry on and change the permissions of other properties. However for a user using a screen reader that is not the case. After changing a permission the focus then moves to the popup notice. This has to be closed before the user can continue but the focus is returned to the url bar and they then have to navigate through the entire page again.
the same is true for all alerts although it is particularly bad with this one.
Part one is to stop moving the focus to the popup notice and this change is in the custom element and can be found here joomla-projects/custom-elements#120
This adds the attribute aria-live to the message container. This will ensure that the message will be announced by the screenreader even though we don't give it focus. Note it must be on the message container because the aria-live must be present in the document on page load - even if there are no messages - for aria-live to work.
aria-live=polite means that the message will be announced next ie after what is being announced now
there is another option which is not appropriate here
aria-live=assertive which means that the message will interrupt anything currently being announced.
Testing without a screen reader is hard. The best test without one is to check that after this pr the div with the id system-message-container looks like this when there is no message displayed
`<div id="system-message-container" aria-live="polite">
<div id="system-message">
</div>
</div>`
The alert custom-element has the ability to be autodismissed after a period of time (often called a growl notification). This ability can now be enabled without breaking the accessibility
Status | New | ⇒ | Pending |
Category | ⇒ | Layout |
This is what I see:
When no alert message
<div id="system-message-container" aria-live="polite">
<div id="system-message">
</div>
</div>
When there is an alert message:
<div id="system-message-container" aria-live="polite">
<div id="system-message">
</div>
<joomla-alert type="info" dismiss="true" role="alert" class="joomla-alert--show"><button class="joomla-alert--close" aria-label="Close">
<span aria-hidden="true">×</span></button><h4 class="alert-heading">Notice</h4><div>Permissions changed in a group with child groups. Save or reload to recalculate the child groups permissions.</div></joomla-alert>
</div>
I fixed the instructions . Thanks for testing. Thats a successful test.
I have tested this item
Labels |
Added:
?
?
|
Merged in the 4.0 branch here so we get the new custom elements. Can someone just quickly retest so we have these in combination please
I have tested this item
Status | Pending | ⇒ | Ready to Commit |
RTC
Labels |
Added:
?
|
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-07-22 07:43:46 |
Closed_By | ⇒ | HLeithner |
thx
Thanks
Can't see code from
Testing
instruction from above @brianteeman