? ? ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
4 Jul 2019

When changing the permission of something if there is a child group then a popup notice is displayed. For a sighted user they can still carry on and change the permissions of other properties. However for a user using a screen reader that is not the case. After changing a permission the focus then moves to the popup notice. This has to be closed before the user can continue but the focus is returned to the url bar and they then have to navigate through the entire page again.

the same is true for all alerts although it is particularly bad with this one.

The fix is in two parts.

Part one is to stop moving the focus to the popup notice and this change is in the custom element and can be found here joomla-projects/custom-elements#120

This is part two

This adds the attribute aria-live to the message container. This will ensure that the message will be announced by the screenreader even though we don't give it focus. Note it must be on the message container because the aria-live must be present in the document on page load - even if there are no messages - for aria-live to work.

aria-live=polite means that the message will be announced next ie after what is being announced now
there is another option which is not appropriate here
aria-live=assertive which means that the message will interrupt anything currently being announced.

Testing

Testing without a screen reader is hard. The best test without one is to check that after this pr the div with the id system-message-container looks like this when there is no message displayed

`<div id="system-message-container" aria-live="polite">
	<div id="system-message">
			</div>
</div>`

Bonus

The alert custom-element has the ability to be autodismissed after a period of time (often called a growl notification). This ability can now be enabled without breaking the accessibility

Votes

# of Users Experiencing Issue
1/1
Average Importance Score
2.00

avatar brianteeman brianteeman - open - 4 Jul 2019
avatar brianteeman brianteeman - change - 4 Jul 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 4 Jul 2019
Category Layout
avatar brianteeman brianteeman - change - 4 Jul 2019
The description was changed
avatar brianteeman brianteeman - edited - 4 Jul 2019
avatar manojLondhe
manojLondhe - comment - 4 Jul 2019

Can't see code from Testing instruction from above @brianteeman

avatar manojLondhe
manojLondhe - comment - 4 Jul 2019

This is what I see:

When no alert message

<div id="system-message-container" aria-live="polite">
	<div id="system-message">
			</div>
</div>

When there is an alert message:

<div id="system-message-container" aria-live="polite">
	<div id="system-message">
			</div>
<joomla-alert type="info" dismiss="true" role="alert" class="joomla-alert--show"><button class="joomla-alert--close" aria-label="Close">
<span aria-hidden="true">×</span></button><h4 class="alert-heading">Notice</h4><div>Permissions changed in a group with child groups. Save or reload to recalculate the child groups permissions.</div></joomla-alert>
</div>

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25421.
avatar brianteeman brianteeman - change - 4 Jul 2019
The description was changed
avatar brianteeman brianteeman - edited - 4 Jul 2019
avatar brianteeman
brianteeman - comment - 4 Jul 2019

I fixed the instructions . Thanks for testing. Thats a successful test.

avatar manojLondhe manojLondhe - test_item - 4 Jul 2019 - Tested successfully
avatar manojLondhe
manojLondhe - comment - 4 Jul 2019

I have tested this item successfully on 52f1de9


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25421.

avatar wilsonge wilsonge - change - 4 Jul 2019
Labels Added: ? ?
avatar wilsonge
wilsonge - comment - 4 Jul 2019

Merged in the 4.0 branch here so we get the new custom elements. Can someone just quickly retest so we have these in combination please

avatar brianteeman
brianteeman - comment - 21 Jul 2019

Can someone please test this so that @wilsonge can merge it. There are other PR waiting on this

avatar richard67
richard67 - comment - 21 Jul 2019

I have tested this item successfully on b3ac75a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25421.

avatar richard67 richard67 - test_item - 21 Jul 2019 - Tested successfully
avatar Quy Quy - change - 21 Jul 2019
Status Pending Ready to Commit
avatar Quy
Quy - comment - 21 Jul 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/25421.

avatar brianteeman brianteeman - change - 21 Jul 2019
Labels Added: ?
avatar HLeithner HLeithner - change - 22 Jul 2019
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-07-22 07:43:46
Closed_By HLeithner
avatar HLeithner HLeithner - close - 22 Jul 2019
avatar HLeithner HLeithner - merge - 22 Jul 2019
avatar HLeithner
HLeithner - comment - 22 Jul 2019

thx

avatar brianteeman
brianteeman - comment - 22 Jul 2019

Thanks

Add a Comment

Login with GitHub to post a comment