[#23985] - [4.0] [a11y] Incorrect buttons
- Fixed in Code Base
- 27 Feb 2019
- Medium
- Build: 4.0-dev
- # 23985
- Diff
- brianteeman:append
User tests: Successful: Unsuccessful:
Pr for #23977
This PR does TWO things
- It changes links into buttons
- It changes the class from sr-only to hidden
(sr-only visually hides something. hidden completely hides it)
To test
As some javascript was changed you will need to run npm i
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_categories com_contact com_content com_menus com_newsfeeds JavaScript Repository NPM Change |
href attribute is not a valid attribute of the button tag.
@zwiastunsw I did what you asked for
Use the
buttontag in all cases.
The button element cannot have the href attribute. The action should be called e.g. using the data-target attribute. Replace attributes, e.g.
from
. ' href="#ModalNew' . $modalId . '"'to
. ' data-target="#ModalNew' . $modalId . '"'| Labels |
Added:
NPM Resource Changed
?
|
||
@zwiastunsw changed as requested
In case of Clair buttons ( // Clear category button, // Clear contact button, // Clear article button, // Clear menu item button, // Clear newsfeed button) change:
. ' data-target="#"'
to
. ' type="button"'
In this case the action is defined in the onclick attribute.
The attribute data-target is not needed in this cases. The attribute type="button" is missing.
thx
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23985.
sorry it took so many iterations. my brain wasnt working
@brianteeman
Could you improve the links to buttons in the footers of the modal window in the same files?
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23985.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23985.
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-02-27 12:42:16 |
| Closed_By | ⇒ | wilsonge |
Thanks!
thanks
@zwiastunsw This should be what you were asking for