[#23984] - Fix fatal error on repeatable-table.php
- Fixed in Code Base
- 4 Mar 2019
- Medium
- Build: staging
- # 23984
- Diff
- Quy:patch-1
User tests: Successful: Unsuccessful:
Pull Request for Issue #23982
Summary of Changes
Prior to PHP 5.5, empty() only supports variables; anything else will result in a parse error
Testing Instructions
Use Joomla subform on PHP older than 5.5
Actual result
Fatal error: Can't use function return value in write context in /home/content/76/10380776/html/imbarcoimmediato/layouts/joomla/form/field/subform/repeatable-table.php on line 59
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Layout |
| Labels |
Added:
?
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23984.
@joomdonation Please test. Thanks.
It works. But maybe we can just change the code to if ($field->description) instead of adding a new variable. Same for this line https://github.com/joomla/joomla-cms/blob/staging/layouts/joomla/form/field/subform/repeatable-table.php#L44 (change to if ($fieldset->description).
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23984.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23984.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23984.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-03-04 20:25:56 |
| Closed_By | ⇒ | HLeithner | |
| Labels |
Added:
?
|
||
thx
Use a different variable name please.
$descriptionis already used:joomla-cms/layouts/joomla/form/field/subform/repeatable-table.php
Line 23 in 35b65c4