[#23986] - Feature/unit tests
- Fixed in Code Base
- 10 Mar 2019
- Medium
- Build: 4.0-dev
- # 23986
- Diff
- dneukirchen:feature/unit-tests
User tests: Successful: Unsuccessful:
This PR brings the unit tests back to the core as discussed in #23962
- added psr-4 autoloading for tests using composer
- namespaced unit tests
- added unit tests
- refactored existing unit tests
- removed useless unit tests
- re-integrated some of the unit tests that are currently not running
- added UnitTestCase as a base class
- updated build tools
- fixed one bug in Mail class which surprisingly was not detected by previous unit tests
before: OK (123 tests, 144 assertions)
after: Tests: 443, Assertions: 678, Skipped: 1.
Testing instructions:
Code review + run phpunit
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Unit Tests External Library Composer Change Repository |
| Labels |
Added:
?
?
?
|
||
@dgrammatiko yes, the plan is to move all test suites back to repo. would be nice if you can do the js part. when you merge js tests back, it would be nice to update karma because of an sec issue in one of its dev dependencies. tried to reach you on glip to talk about it. we are using karma 0.13, current version is 4. karma 2+ should fix it.
@dneukirchen ok, I will try to do a PR this weekend
- it includes more unit tests (re-enabled some of the old unit tests which did not run for j4)
- tests are namespaced and psr-4 autoloaded
- tests use namespaced classes
- useless tests and integration tests in unit test suite are removed
- refactored some of the tests
While we are at it: Appveyor has a bunch of errors in its output. I doubt that it should be like that...
looks good to me
What is the difference between this pull request and #23962?
I'll jsut leave this here: joomla/test-unit#9
| Category | Unit Tests External Library Composer Change Repository | ⇒ | Unit Tests External Library Composer Change Libraries Repository |
Rtc?
@dneukirchen cross referencing
#24044
fixed merge conflict.
ping @rdeutz @wilsonge @HLeithner can we get this merged?
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-03-10 14:20:12 |
| Closed_By | ⇒ | rdeutz |
@dgrammatiko I am on it
Hmm.
tests/Unit/Libraries/Cms/Mircodata/MicrodataTest.php
Mircodata ??
Also it looks like these new files have not been added as indexed to the branch.
@dneukirchen are you gonna bring the javascript tests as well? Do you want me to do aPR for that?
Is that also considered at this point?