? ? Pending

User tests: Successful: Unsuccessful:

avatar wojsmol
wojsmol
8 Feb 2019

Problem diagnosed by the JAT team.
All switches have a non-existent name aria attribute: aria-labeledby. Should be: aria-labelledby (two letters "l")

If the developer uses a non-existent or misspelled ARIA attribute, the attribute will not be able to perform the accessibility function intended by the developer.

Summary of Changes

Invalid attribute replaced with correct attribute

Testing Instructions

Code review

Note

This may be the reason that labels are not announced by the screen reader.

avatar wojsmol wojsmol - open - 8 Feb 2019
avatar wojsmol wojsmol - change - 8 Feb 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 8 Feb 2019
Category JavaScript Repository
avatar brianteeman
brianteeman - comment - 9 Feb 2019

Good spot

avatar brianteeman
brianteeman - comment - 9 Feb 2019

I have tested this item successfully on e10edb9


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23834.

avatar brianteeman brianteeman - test_item - 9 Feb 2019 - Tested successfully
avatar chmst
chmst - comment - 9 Feb 2019

I have tested this item successfully on e10edb9


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23834.

avatar chmst chmst - test_item - 9 Feb 2019 - Tested successfully
avatar Quy Quy - change - 9 Feb 2019
Status Pending Ready to Commit
avatar Quy
Quy - comment - 9 Feb 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23834.

avatar wilsonge wilsonge - change - 13 Feb 2019
Labels Added: ?
avatar wilsonge wilsonge - change - 14 Feb 2019
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-02-14 09:46:36
Closed_By wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 14 Feb 2019
avatar wilsonge wilsonge - merge - 14 Feb 2019
avatar wilsonge
wilsonge - comment - 14 Feb 2019

Thanks!

avatar wojsmol wojsmol - change - 20 Feb 2019
Title
[4.0][a11n] Incorrectly named ARIA attribute
[4.0][a11y] Incorrectly named ARIA attribute
avatar wojsmol wojsmol - edited - 20 Feb 2019
avatar joomla-cms-bot joomla-cms-bot - change - 20 Feb 2019
Category JavaScript Repository JavaScript Repository NPM Change

Add a Comment

Login with GitHub to post a comment