[#23833] - [4.0] Added box-shadow to user dropdown menu
- Closed
- 16 Apr 2019
- Medium
- Build: 4.0-dev
- # 23833
- Diff
- hardik-codes:boxShadow
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
- Success continuous-integration/drone/pr the build was successful Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #23791
Summary of Changes
Added box-shadow:0px 8px 10px #C0C0C0, -10px 8px 15px #C0C0C0, 10px 8px 15px #C0C0C0; to the .dropdown-menu selector in the file administrator/templates/atum/scss/blocks/_header.scss
Testing Instructions
Open the user dropdown menu
Expected result
Actual result
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Templates (admin) |
| Title |
|
||||||
To keep shadows consistent, use the available box-shadow variable... https://github.com/joomla/joomla-cms/blob/4.0-dev/administrator/templates/atum/scss/_variables.scss#L62
But the box-shadow variable cannot be used as it is because of shadows on 3 sides so instead of using the variable may I use the values directly for consistency?
If you wish you can create a new dropdown box-shadow variable if you feel the current variable is not suitable. Up to you but I would consider '0px 8px 10px #C0C0C0, -10px 8px 15px #C0C0C0, 10px 8px 15px #C0C0C0;' excessive.
If I read this correctly then this is not correct for RTL
@brianteeman apart from the box-shadow on 3 sides what else could be done so that it is correct for RTL
The three sides are different in rtl
Different in the widths?
@brianteeman - When he says 3 sides, he means left/right/bottom and this works perfectly fine on RTL.
@hardik-codes - Using the variable mentioned by @ciar4n is fine
| Labels |
Added:
?
|
||
Changed the commit message successfully !!
Sorry for the confusion
I applied this path via git fetch origin pull/23833/head:boxShadow and run npm install.
Before:
After:
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23833.
There is a visible outline without this PR.
Here is the backend of the new design. Shadow is no longer an issue. I recommend closing this PR.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-04-16 15:28:15 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Removed:
J4 Issue
|
||
@C-Lodder please review the PR