[#23660] - Add layouts to plg_system_privacyconsent
- Fixed in Code Base
- 19 Feb 2019
- Medium
- Build: staging
- # 23660
- Diff
- Ruud68:privacyconsentlayouts
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success continuous-integration/drone/pr the build was successful Details
- Failure continuous-integration/appveyor/pr AppVeyor build failed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Pull Request for Issue # n/a.
Summary of Changes
the layouts for plg_system_privacyconsent (label and privacynote) are hardcoded into the field and cannot be overwritten by a template override
This PR adds layouts for both the label and for the privacynote (message). these layouts can be overwritten via template overrides.
Testing Instructions
- enable the privacyconsent system plugin
- set a joomla article as privacy article in the plugin
on the front-end user registration page the privacyconsent box should show
Apply this PR
[test] on the front-end user regsitration page the privacyconsent box should be exactly the same as without this PR.
- create a template override via the template (e.g. protostar):
-> tab Create Overrides
-> column Layouts
-> select plugins > system (new!)
Edit the created override file: ./templates/protostar/html/layouts/plugins/system/privacyconsent/message.php
4. change the class from alert-info to alert-warning
[Result 1] refresh on the front-end the new user registration form
Edit the created override file: ./templates/protostar/html/layouts/plugins/system/privacyconsent/label.php
5. change <span class="star"> *</span></label> to <span class="star">©*</span></label>
[Result 2] refresh on the front-end the new user registration form
New result
Actual result
Make sure that after applying the PR everything works as before.
Documentation Changes Required
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Layout Front End Plugins |
| Labels |
Added:
?
|
||
Thanks for testing @viocassel
Please fix the file permissions on the privacy field
I have tested this item
I have tested this item successfully.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23660.
I have tested this item
I have tested this item successfully.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23660.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23660.
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23660.
same change for plg_user_terms: https://issues.joomla.org/tracker/joomla-cms/23787
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23660.
| Labels |
Added:
?
|
||
I have tested this item
I have tested this item successfully on 3.9.3.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23660.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23660.
thx
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-02-19 15:09:26 |
| Closed_By | ⇒ | HLeithner |
I have tested this item✅ successfully on 2c75abd
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23660.