[#23661] - [4.0] Move sidebar modules into grid
- Fixed in Code Base
- 23 Jun 2019
- Medium
- Build: 4.0-dev
- # 23661
- Diff
- ciar4n:grid-has-module
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
- Failure continuous-integration/drone/pr the build failed Details
- Pending JTracker/HumanTestResults Human Test Results: 1 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
Moves the sidebar modules into the main CSS grid by using has-* classes.
- Less nested divs
- Less hacky
- Potential scope for IE11 CSS grid support (using old grid spec).
For a more detailed explanation.. https://joomla51.com/blog/item/joomla-css-grid-and-dynamic-content
Testing Instructions
Apply patch (cant use patchtester) and compile CSS. Check frontend layout with modules enabled/disabled in the sidebar-left and sidebar-right modules positions
Votes
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Templates (site) |
| Labels |
Added:
?
|
||
| Labels |
Removed:
J4 Issue
|
||
Appreciate if I could get a second test on this. Without it, the grid is just a single column. Defeats the purpose of using CSS grid. Might as well just use flex.
I have tested this item
Works for me.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23661.
I have tested this item
Works for me.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23661.
@roland-d @infograf768 Thank you. RTC?
| Status | Pending | ⇒ | Ready to Commit |
rtc
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23661.
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-06-23 16:23:13 |
| Closed_By | ⇒ | wilsonge |
Thanks!
I have tested this item✅ successfully on 3e4f52e
Code is cleaner after applying the patch.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23661.