NPM Resource Changed ? ? Pending

User tests: Successful: Unsuccessful:

avatar chmst
chmst
24 Jan 2019

Summary of Changes

Replace the aria attribute "aria-sorted" by the correct attribute "aria-sort"

Testing Instructions

for example com_content/articles, reorder the table via the table header and inspect the source code. The aria attribute "aria-sorted" is set.
Use AXE to get the error "wrong attribute aria-sorted".

Apply the patch (don't forget the npm i)

The attribute is now "aria-sort" and AXE is satisfied.

avatar chmst chmst - open - 24 Jan 2019
avatar chmst chmst - change - 24 Jan 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 24 Jan 2019
Category JavaScript Repository
avatar chmst chmst - change - 24 Jan 2019
Title
Fix aria attribute aria-sort
[a11y] Fix aria attribute aria-sort
avatar chmst chmst - edited - 24 Jan 2019
avatar zwiastunsw
zwiastunsw - comment - 25 Jan 2019

I have tested this item successfully on 0c47702


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23662.

avatar zwiastunsw zwiastunsw - test_item - 25 Jan 2019 - Tested successfully
avatar bembelimen
bembelimen - comment - 25 Jan 2019

I have tested this item successfully on 0c47702


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23662.

avatar bembelimen bembelimen - test_item - 25 Jan 2019 - Tested successfully
avatar Quy Quy - change - 25 Jan 2019
Status Pending Ready to Commit
avatar Quy
Quy - comment - 25 Jan 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23662.

avatar brianteeman
brianteeman - comment - 26 Jan 2019

I have tested this item successfully on 0c47702

My fault - oops


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23662.

avatar brianteeman brianteeman - test_item - 26 Jan 2019 - Tested successfully
avatar brianteeman
brianteeman - comment - 17 Feb 2019

Can you fix the conflicts please

avatar chmst chmst - change - 17 Feb 2019
Labels Added: ?
avatar wilsonge wilsonge - change - 18 Feb 2019
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 19 Feb 2019
Category JavaScript Repository JavaScript Repository NPM Change
avatar wilsonge wilsonge - change - 19 Feb 2019
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-02-19 23:32:50
Closed_By wilsonge
Labels Added: NPM Resource Changed
avatar wilsonge wilsonge - close - 19 Feb 2019
avatar wilsonge wilsonge - merge - 19 Feb 2019
avatar wilsonge
wilsonge - comment - 19 Feb 2019

Thanks!

Add a Comment

Login with GitHub to post a comment