?

Success

User tests: Successful: Unsuccessful:

avatar Ruud68
Ruud68
7 Feb 2019

Pull Request for Issue # n/a.

Summary of Changes

the layouts for plg_user_terms (label and termsnote) are hardcoded into the field and cannot be overwritten by a template override
This PR adds layouts for both the label and for the termsnote (message). these layouts can be overwritten via template overrides.

Testing Instructions

  1. enable the terms userm plugin
  2. set a joomla article as terms article in the plugin
    on the front-end user registration page the terms box should show

Apply this PR

[test] on the front-end user regsitration page the terms box should be exactly the same as without this PR.

  1. create a template override via the template (e.g. protostar):
    -> tab Create Overrides
    -> column Layouts
    -> select plugins > user

Edit the created override file: ./templates/protostar/html/layouts/plugins/user/terms/message.php
4. change the class from alert-info to alert-warning

[Result 1] refresh on the front-end the new user registration form

Edit the created override file: ./templates/protostar/html/layouts/plugins/user/terms/label.php
5. change <span class="star">&#160;*</span></label> to <span class="star">&copy;*</span></label>

[Result 2] refresh on the front-end the new user registration form

New result

image

Actual result

Make sure that after applying the PR everything works as before.

Documentation Changes Required

avatar Ruud68 Ruud68 - open - 7 Feb 2019
avatar Ruud68 Ruud68 - change - 7 Feb 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 7 Feb 2019
Category Layout Front End Plugins
avatar tecpromotion
tecpromotion - comment - 8 Feb 2019

I have tested this item successfully on c56805f

I have tested this item successfully on 3.9.2.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23787.

avatar tecpromotion tecpromotion - test_item - 8 Feb 2019 - Tested successfully
avatar Ruud68
Ruud68 - comment - 8 Feb 2019

Thanks for testing @tecpromotion :) Appreciate it!


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23787.

avatar Ruud68
Ruud68 - comment - 8 Feb 2019

Thanks for testing @tecpromotion :) Appreciate it!


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23787.

avatar Ruud68 Ruud68 - change - 8 Feb 2019
Labels Added: ?
avatar viocassel
viocassel - comment - 9 Feb 2019

I have tested this item successfully on 13a7114


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23787.

avatar viocassel viocassel - test_item - 9 Feb 2019 - Tested successfully
avatar Ruud68
Ruud68 - comment - 9 Feb 2019

Thanks for testing @viocassel

avatar Ruud68
Ruud68 - comment - 14 Feb 2019

@Quy I see two successful tests, only one is counted? Do you know why and what is needed for this to go RTC?


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23787.

avatar Bakual
Bakual - comment - 14 Feb 2019

When a new commit is made after a test, you need to retest it. The old tests don't count anymore.

avatar Ruud68
Ruud68 - comment - 14 Feb 2019

@Bakual which is strange, because the one counted as successful is the one before the last change? anyway @viocassel and @tecpromotion just to make sure, can you both (re) test #please :)

avatar Bakual
Bakual - comment - 14 Feb 2019

It shows the one from Vio as successful one. The first one from Stefan is discarded since you did two commits afterwards.
image
So @tecpromotion or someone else has to test (again).

avatar tecpromotion
tecpromotion - comment - 18 Feb 2019

I have tested this item successfully on 7ff2f05

I have tested this item successfully on 3.9.3.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23787.

avatar tecpromotion tecpromotion - test_item - 18 Feb 2019 - Tested successfully
avatar viocassel
viocassel - comment - 18 Feb 2019

I have tested this item successfully on 7ff2f05


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23787.

avatar viocassel viocassel - test_item - 18 Feb 2019 - Tested successfully
avatar HLeithner HLeithner - change - 19 Feb 2019
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-02-19 09:38:25
Closed_By HLeithner
avatar HLeithner HLeithner - close - 19 Feb 2019
avatar HLeithner HLeithner - merge - 19 Feb 2019
avatar HLeithner
HLeithner - comment - 19 Feb 2019

thx

Add a Comment

Login with GitHub to post a comment