[#23787] - Add layouts to plg_user_terms
- Fixed in Code Base
- 19 Feb 2019
- Medium
- Build: staging
- # 23787
- Diff
- Ruud68:plgusertermslayouts
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
- Success continuous-integration/drone/pr the build was successful Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Pull Request for Issue # n/a.
Summary of Changes
the layouts for plg_user_terms (label and termsnote) are hardcoded into the field and cannot be overwritten by a template override
This PR adds layouts for both the label and for the termsnote (message). these layouts can be overwritten via template overrides.
Testing Instructions
- enable the terms userm plugin
- set a joomla article as terms article in the plugin
on the front-end user registration page the terms box should show
Apply this PR
[test] on the front-end user regsitration page the terms box should be exactly the same as without this PR.
- create a template override via the template (e.g. protostar):
-> tab Create Overrides
-> column Layouts
-> select plugins > user
Edit the created override file: ./templates/protostar/html/layouts/plugins/user/terms/message.php
4. change the class from alert-info to alert-warning
[Result 1] refresh on the front-end the new user registration form
Edit the created override file: ./templates/protostar/html/layouts/plugins/user/terms/label.php
5. change <span class="star"> *</span></label> to <span class="star">©*</span></label>
[Result 2] refresh on the front-end the new user registration form
New result
Actual result
Make sure that after applying the PR everything works as before.
Documentation Changes Required
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Layout Front End Plugins |
Thanks for testing @tecpromotion :) Appreciate it!
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23787.
Thanks for testing @tecpromotion :) Appreciate it!
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23787.
| Labels |
Added:
?
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23787.
Thanks for testing @viocassel
@Quy I see two successful tests, only one is counted? Do you know why and what is needed for this to go RTC?
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23787.
When a new commit is made after a test, you need to retest it. The old tests don't count anymore.
@Bakual which is strange, because the one counted as successful is the one before the last change? anyway @viocassel and @tecpromotion just to make sure, can you both (re) test #please :)
It shows the one from Vio as successful one. The first one from Stefan is discarded since you did two commits afterwards.
So @tecpromotion or someone else has to test (again).
I have tested this item
I have tested this item successfully on 3.9.3.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23787.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23787.
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-02-19 09:38:25 |
| Closed_By | ⇒ | HLeithner |
thx
I have tested this item✅ successfully on c56805f
I have tested this item successfully on 3.9.2.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23787.