? Pending

User tests: Successful: Unsuccessful:

avatar dgrammatiko
dgrammatiko
7 Feb 2019

Pull Request for Issue # .

Summary of Changes

The second part of the refactoring of the npm build tools.

  • Templates get an src assets_source folder which can have subfolders for css, js or scss

  • Scss files compiled (unmagnified and minified as well) and stored in the usual template/css

  • CSS files get copied over to the usual template/css folder and minified as well

  • JS files can be any of the 3 versions already introduced in the previous PR (.es6.js, .es5.js and .w-c.es6.js) The respective product of these will be placed in template/js

  • Watch gets the second round of revamp also it gets more specific.

  • Without any param will watch the build/media_source folder

  • Can also accept administrator/templates so someone can work on a backend template

  • or templates and this will watch the front end templates

  • ATM it will not handle plain css files (that will be on the next PR)

  • Also there is no logic to synchronise the removal of a source file to be correctly reflected in the distribution folders (again that's for the next PR)

Testing Instructions

  • apply patch
  • run npm init
  • run node run build.js --watch

edit the file joomla-cms/build/media_source/plg_installer_webinstaller/scss/client.scss check if the css and .min.css in the media forder was updated

Create a file joomla-cms/build/media_source/plg_installer_webinstaller/scss/test.scss with any valid code (eg body {display:none;} ) check if the css and .min.css in the media forder was created

press ctrl+c to quit the watch.

Repeat the procedure but this time use node run build.js --watch administrator/templates and edit create a file in the atum/src/scss folder

Happy coding 🍸

Expected result

Actual result

Documentation Changes Required

Based on the #23723

094cfd0 30 Jan 2019 avatar dgrammatiko oops
148e570 31 Jan 2019 avatar dgrammatiko CS
avatar dgrammatiko dgrammatiko - open - 7 Feb 2019
avatar dgrammatiko dgrammatiko - change - 7 Feb 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 7 Feb 2019
Category Administration com_categories com_config com_content com_media com_modules Templates (admin) JavaScript
avatar dgrammatiko
dgrammatiko - comment - 7 Feb 2019

@Hackwar so no files moved to media...

avatar dgrammatiko dgrammatiko - change - 7 Feb 2019
Title
[4.0] Refactor the build tools
[4.0] Refactor the build tools pt.2
avatar dgrammatiko dgrammatiko - edited - 7 Feb 2019
avatar dgrammatiko dgrammatiko - change - 7 Feb 2019
Labels Added: ?
avatar dgrammatiko dgrammatiko - change - 7 Feb 2019
Title
[4.0] Refactor the build tools pt.2
[4.0][NO CACHE] Refactor the build tools pt.2
avatar dgrammatiko dgrammatiko - edited - 7 Feb 2019
416e0f4 7 Feb 2019 avatar dgrammatiko CS
226032e 7 Feb 2019 avatar dgrammatiko CS
avatar joomla-cms-bot joomla-cms-bot - change - 7 Feb 2019
Category Administration com_categories com_config com_content com_media com_modules Templates (admin) JavaScript Administration Templates (admin) JavaScript
avatar dgrammatiko
dgrammatiko - comment - 8 Feb 2019

@wilsone more pain here, sorry 😐. I promise this is the last one, after this one any changes will be only on the build tools script, no more files moving around...

avatar joomla-cms-bot joomla-cms-bot - change - 10 Feb 2019
Category Administration Templates (admin) JavaScript Administration Templates (admin)
avatar dgrammatiko dgrammatiko - change - 10 Feb 2019
The description was changed
avatar dgrammatiko dgrammatiko - edited - 10 Feb 2019
avatar dgrammatiko
dgrammatiko - comment - 26 Mar 2019

@wilsonge let me know if you want to merge this otherwise I'll just close it

avatar wilsonge
wilsonge - comment - 26 Mar 2019

OK I want it - but i'd like to keep the scss folder top level please. Also we need to gitignore the template css and js files (especially the minified version if/when we go this way)

avatar dgrammatiko dgrammatiko - change - 2 Apr 2019
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2019-04-02 11:07:54
Closed_By dgrammatiko
avatar dgrammatiko dgrammatiko - close - 2 Apr 2019

Add a Comment

Login with GitHub to post a comment