J4 Issue ?
avatar continga
continga
24 Jan 2019

As discussed in #22446 we need to remove the plg_fields_repeatable plugin as soon as #22446 is merged into 3.10-dev

Background: Pull request #22446 implements a new custom field type plg_fields_subfields which is capable of using predefined custom fields for use as sub fields of a subform containing those. This functionality is basically an expansion of the functionality of the plg_fields_repeatable type. Hence, to keep the Joomla! core clean, we need to remove the plg_fields_repeatable plugin.

What needs to be done is that the plg_fields_repeatable plugin needs to be removed for all new installations of Joomla!, and for all existing installations that do not use that plugin (so have no repeatable custom fields). For installations that use it, we need to either provide a transitioning-script, or we need to explain the user how to switch from the repeatable type to the subfields type. To accomplish this, we maybe first need to declare the plg_fields_subfields type as deprecated in a first step.

A first idea of how to remove the repeatable type from core and how to build a transitioning script can be found in this diff continga@71f831d
That diff was previously part of the beforementioned PR, but we decided to do the plg_fields_repeatable stuff in a separate issue and keep it outside of the scope of the plg_fields_subfields PR. That is the reason this issue got created.

So in a first place, we need to decide on the actions that need to be taken in regards to the plg_fields_repeatable plugin when #22446 got merged, and when we have decided and when #22446 is merged, we need to create an additional PR for this.

avatar continga continga - open - 24 Jan 2019
avatar joomla-cms-bot joomla-cms-bot - change - 24 Jan 2019
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 24 Jan 2019
avatar franz-wohlkoenig franz-wohlkoenig - change - 3 Mar 2019
Status New Information Required
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 3 Mar 2019

@infograf768 can you please comment?

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 16 Mar 2019

@infograf768 reminder

avatar infograf768
infograf768 - comment - 16 Mar 2019

As it looks that #22446 is not going to go into 3.x and is not changed to be targeted at 4.0, this Issue looks out of scope for now.
The proposed code should imho be added to #22446 if necessary in order to merge both together when proposed and accepted.

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 16 Mar 2019

@infograf768 thanks for Comment. So its for @HLeithner or @wilsonge

avatar HLeithner
HLeithner - comment - 17 Mar 2019

We can't remove anything in a minor version. At least not following the semver definition.
Beside this, how should this work what happens to layout overrides?

avatar micker
micker - comment - 17 Mar 2019

I think repetable field is already use in many extension ... Try to start migration now Can be interesting now for less work on j4 migration

avatar HLeithner
HLeithner - comment - 18 Mar 2019

Migration seams not to be the problem (script is ready) but layout overrides may have to be changed.

avatar wilsonge
wilsonge - comment - 18 Mar 2019

It would make sense in this case to merge #22446 so people have a version where they can migrate their fields out of repeatable and into the subform field. But yes the repeatable field cannot be removed until 4.0 - but we can of course mark it as deprecated as soon as that is merged

avatar wilsonge
wilsonge - comment - 18 Mar 2019

AMENDMENT TO ABOVE: Apologies. I missed there was a migration script. If there's a migration script then the correct place to do that migration is in 4.0 and not have this in 3.10! Sorry!

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 28 Mar 2019

changed Title cause of above Comment by @wilsonge

avatar franz-wohlkoenig franz-wohlkoenig - change - 28 Mar 2019
Title
[3.10] Remove plg_fields_repeatable
[4.0] Remove plg_fields_repeatable
Status Information Required Discussion
avatar joomla-cms-bot joomla-cms-bot - edited - 28 Mar 2019
avatar franz-wohlkoenig franz-wohlkoenig - change - 28 Mar 2019
Category Fields
avatar franz-wohlkoenig franz-wohlkoenig - change - 4 Apr 2019
Labels Added: J4 Issue
avatar franz-wohlkoenig franz-wohlkoenig - labeled - 4 Apr 2019
avatar wilsonge wilsonge - change - 11 Nov 2019
Labels Added: ?
avatar wilsonge wilsonge - labeled - 11 Nov 2019
avatar wilsonge
wilsonge - comment - 11 Nov 2019

Adding release blocker label as this needs to be solved for 4.0 stable

avatar wilsonge wilsonge - change - 28 Jan 2020
Labels Added: ?
avatar wilsonge wilsonge - labeled - 28 Jan 2020
avatar jwaisner jwaisner - change - 17 Feb 2020
Priority Medium Urgent
avatar joomla-cms-bot joomla-cms-bot - change - 17 Feb 2020
Labels Removed: ?
avatar joomla-cms-bot joomla-cms-bot - unlabeled - 17 Feb 2020
avatar jwaisner
jwaisner - comment - 17 Feb 2020

Increasing priority as per guidelines for beta-blockers.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/23659.

avatar jwaisner jwaisner - change - 17 Feb 2020
Labels Added: ?
avatar jwaisner jwaisner - labeled - 17 Feb 2020
avatar Quy
Quy - comment - 11 Mar 2020

See PR #28319 Draft.

avatar Quy Quy - close - 11 Mar 2020
avatar Quy Quy - change - 11 Mar 2020
Status Discussion Closed
Closed_Date 0000-00-00 00:00:00 2020-03-11 23:58:03
Closed_By Quy
Labels Added: ?
Removed: ?
avatar wilsonge wilsonge - change - 18 Mar 2020
Labels Removed: ?
avatar wilsonge wilsonge - unlabeled - 18 Mar 2020
avatar wilsonge wilsonge - change - 18 Dec 2020
Labels Removed: ?
avatar wilsonge wilsonge - unlabeled - 18 Dec 2020

Add a Comment

Login with GitHub to post a comment