Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#21505] - [4.0] Fix npm script on windows

? Pending

User tests: Successful: Unsuccessful:

avatar Bakual
Bakual
9 Aug 2018

Currently, if you run npm install on a Windows machine, the compiled JS files aren't moved to the correct folder. Git will show a bunch of untracked files in /build/media_src

Summary of Changes

This adjusts the script for Windows folders. Code comes from @dgrammatiko (Thanks!).

Testing Instructions

Run npm install

Please test both on Linux and Windows.

Expected result

Works

Actual result

Doesn't work on Windows

Documentation Changes Required

None

avatar Bakual Bakual - open - 9 Aug 2018
avatar Bakual Bakual - change - 9 Aug 2018
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 9 Aug 2018
Category ⇒ JavaScript Repository
avatar dgrammatiko
dgrammatiko - comment - 9 Aug 2018

@wilsonge please merge this

avatar brianteeman
brianteeman - comment - 9 Aug 2018

Seems to be working fine for me on Windows

avatar Bakual Bakual - change - 9 Aug 2018
Labels Added: ?
avatar roland-d roland-d - test_item - 9 Aug 2018 - Tested successfully
avatar roland-d
roland-d - comment - 9 Aug 2018

I have tested this item ✅ successfully on beca464

After applying the patch the generated files no longer end up in the build/media_src folder.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/21505.

avatar rdeutz rdeutz - change - 9 Aug 2018
Status Pending ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2018-08-09 19:09:02
Closed_By ⇒ rdeutz
avatar rdeutz rdeutz - close - 9 Aug 2018
avatar rdeutz rdeutz - merge - 9 Aug 2018

Add a Comment

Login with GitHub to post a comment