Also:
same corrections should be done for Transitions
Using maybe the existing strings
JTOOLBAR_UNPUBLISH, etc. or new specific COM_WORKFLOW strings

To obtain (here for French. just modified for unpublished)

In both cases Modifier Non Publié for the title is not very nice phrasing. Maybe add a : between.

@infograf768 I'll create a new PR for this, but thanks for the suggestion!

Can conflicts be solved?
And obviously adapted to the new stage name instead of state

Sure, I waited for #21566

I think that also Joomla! Default should be a string btw.

Also conflict with new file name.

And I foresee issues with #21520 as the sql does not use string constants.

Missing Text:: line 118 of tmpl/transitions/default.php to get
<a href="<?php echo $edit; ?>" title="<?php echo Text::_('JACTION_EDIT'); ?> <?php echo Text::_($this->escape(addslashes($item->title))); ?>">

Otherwise good first step for me

Thanks @infograf768

I have tested this item ✅ successfully on 9d0ba73

Let's advance with this.

One more tester, if possible.

I have tested this item ✅ successfully on 9d0ba73

Let's advance with this.

One more tester, if possible.

I have tested this item ✅ successfully on 9d0ba73

Ready to Commit after two successful tests.

https://github.com/joomla/joomla-cms/pull/21506/files#diff-135c6f58583408312a709459b19594c7
it lacks the upgrade path and obviously postgresql

done in bembelimen#22

question:
should we do the same on the #__workflow_transitions ?

Status back on "Pending".

@alikon
I thought we could do that after the follow-up on this.
I explain:

We also need to translate the transitions. I.e. enter in db some string for the actions
Unpublish, Publish, etc.
Then translate the titles in transitions Manager with something like

										<?php echo $editIcon; ?><?php echo Text::_($item->title); ?>
											</a>
										<?php else: ?>
											<?php echo Text::_($item->title); ?>
										<?php endif; ?>

so basically we would have something like

INSERT INTO `#__workflow_transitions` (`id`, `asset_id`, `published`, `ordering`, `workflow_id`, `title`, `description`, `from_stage_id`, `to_stage_id`) VALUES
(1, 0, 1, 1, 1, 'JUNPUBLISH', '', -1, 1),
(2, 0, 1, 2, 1, 'JPUBLISH', '', -1, 2),
(3, 0, 1, 3, 1, 'JTRASH', '', -1, 3),
(4, 0, 1, 4, 1, 'JARCHIVE', '', -1, 4);

And add the new lang strings.
Is it worth changing now db or do it in the next PR?

Or do it in this PR?

Yes we can do in a next PR,

Il ven 24 ago 2018, 07:28 infograf768 notifications@github.com ha scritto:

Or do it in this PR?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#21506 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AALFsUncU2NFikLUdWpf3BuGOLrdUC2Gks5uT47fgaJpZM4V2Qbn
.

@bembelimen
Your decision. If you do transitions in next PR, let's not forget @alikon necessary updated patch.

Thanks @alikon for the PR

I would do the translation in a new PR, so we have small code changes.

Drone error is unrelated to this PR.

@wilsonge Please merge.

rtc

Whoever merges can you directly fix the drone error

Thanks guys!