User tests: Successful: Unsuccessful:
After running npm install, you currently get a bunch of modified template CSS files and one untracked one.
This PR removes the compiled CSS files from the repo and adds them to .gitignore.
Apply PR and run npm install --unsafe-perm
The files are created and the template works
Git shows no changed or untracked CSS files for templates.
Everything works, but Git complains.
None
Status | New | ⇒ | Pending |
Category | ⇒ | Repository Administration Templates (admin) Front End Templates (site) |
Title |
|
I see changed files everytime I run npm install on the repo. Either because they are outdated or because my env compiles them different than when it was commited - I don't know. It's confusing.
I've asked in the maintainer chat if it is intentional and was told to remove them. So no clue
Labels |
Added:
?
|
Category | Repository Administration Templates (admin) Front End Templates (site) | ⇒ | Repository Administration Templates (admin) Installation Front End Templates (site) |
@Bakual @brianteeman the conversation is about moving or not the sources in build/whatever and me proposing to move also the compiled files in media/whatever.
Maybe one reason that I didn't mention before is that having all the static assets under one folder makes the implementation of a service worker for them a 5 line task...
This is the comment from @wilsonge that has perhaps confused me #21306 (comment)
Not sure why he wants to make that dependant on a decision of where those files live in the end.
Imho we either remove all compiled files from the repo or we don't. But having the compiled template CSS files in the repo while all other compiled CSS files are gone makes no sense to me.
Adding them to .gitignore is really not that hard. It's not like we're talking about 100 files. And once the sources are moved to whatever place, we can probably just .gitignore the templates CSS folder instead of single files like now.
Rebased, solved conflicts and made it more complete.
Status | Pending | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-08-22 14:44:41 |
Closed_By | ⇒ | wilsonge |
Not sure why he wants to make that dependant on a decision of where those files live in the end
I thought we were going to have that conversation almost immediately as everything else was happening. but it never happened. So doing this now is fine i guess.
I thought we were keeping those template CSS for now to help with testing so you don't have to do an npm install everyone you need to test a quick CSS change in a pr.
At least that was my understanding