? Pending

User tests: Successful: Unsuccessful:

avatar Bakual
Bakual
9 Aug 2018

After running npm install, you currently get a bunch of modified template CSS files and one untracked one.

Summary of Changes

This PR removes the compiled CSS files from the repo and adds them to .gitignore.

Testing Instructions

Apply PR and run npm install --unsafe-perm

Expected result

The files are created and the template works
Git shows no changed or untracked CSS files for templates.

Actual result

Everything works, but Git complains.

Documentation Changes Required

None

avatar Bakual Bakual - open - 9 Aug 2018
avatar Bakual Bakual - change - 9 Aug 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 9 Aug 2018
Category Repository Administration Templates (admin) Front End Templates (site)
avatar Bakual Bakual - change - 9 Aug 2018
Title
Ignore template css
[4.0] Ignore template css
avatar Bakual Bakual - edited - 9 Aug 2018
avatar brianteeman
brianteeman - comment - 9 Aug 2018

I thought we were keeping those template CSS for now to help with testing so you don't have to do an npm install everyone you need to test a quick CSS change in a pr.

At least that was my understanding

avatar Bakual
Bakual - comment - 9 Aug 2018

I see changed files everytime I run npm install on the repo. Either because they are outdated or because my env compiles them different than when it was commited - I don't know. It's confusing. ?

I've asked in the maintainer chat if it is intentional and was told to remove them. So no clue ?

avatar brianteeman
brianteeman - comment - 9 Aug 2018

Maybe I misunderstood what @wilsonge said

avatar Bakual Bakual - change - 9 Aug 2018
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 9 Aug 2018
Category Repository Administration Templates (admin) Front End Templates (site) Repository Administration Templates (admin) Installation Front End Templates (site)
avatar dgrammatiko
dgrammatiko - comment - 9 Aug 2018

@Bakual @brianteeman the conversation is about moving or not the sources in build/whatever and me proposing to move also the compiled files in media/whatever.
Maybe one reason that I didn't mention before is that having all the static assets under one folder makes the implementation of a service worker for them a 5 line task...

avatar brianteeman
brianteeman - comment - 9 Aug 2018

This is the comment from @wilsonge that has perhaps confused me #21306 (comment)

avatar Bakual
Bakual - comment - 9 Aug 2018

Not sure why he wants to make that dependant on a decision of where those files live in the end.
Imho we either remove all compiled files from the repo or we don't. But having the compiled template CSS files in the repo while all other compiled CSS files are gone makes no sense to me.

Adding them to .gitignore is really not that hard. It's not like we're talking about 100 files. And once the sources are moved to whatever place, we can probably just .gitignore the templates CSS folder instead of single files like now.

avatar Bakual
Bakual - comment - 22 Aug 2018

Rebased, solved conflicts and made it more complete.

avatar Bakual
Bakual - comment - 22 Aug 2018

Rebased again to take care of #21810

avatar wilsonge wilsonge - change - 22 Aug 2018
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2018-08-22 14:44:41
Closed_By wilsonge
avatar wilsonge wilsonge - close - 22 Aug 2018
avatar wilsonge wilsonge - merge - 22 Aug 2018
avatar wilsonge
wilsonge - comment - 22 Aug 2018

Not sure why he wants to make that dependant on a decision of where those files live in the end

I thought we were going to have that conversation almost immediately as everything else was happening. but it never happened. So doing this now is fine i guess.

Add a Comment

Login with GitHub to post a comment