Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#21331] - [4.0] DRY for warning pages

? Pending
Referenced as Duplicate of: # 21369

User tests: Successful: Unsuccessful:

avatar dgrammatiko
dgrammatiko
31 Jul 2018

Pull Request for Issue # .

Summary of Changes

Code refactoring for the two warning pages (unsupported PHP version, incomplete Env)

  • one command for both node build.js --build-check
  • settings stored in the setitngs.json
  • one, html/css/js file

Testing Instructions

Check the generated files in the system template, appart from various CS they are exactly the same! WIN

Expected result

Actual result

Documentation Changes Required

8f4421c 31 Jul 2018 avatar dgrammatiko DRY
avatar dgrammatiko dgrammatiko - open - 31 Jul 2018
avatar dgrammatiko dgrammatiko - change - 31 Jul 2018
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 31 Jul 2018
Category ⇒ JavaScript Repository Front End Templates (site)
avatar dgrammatiko dgrammatiko - change - 31 Jul 2018
Labels Added: ?
avatar wilsonge
wilsonge - comment - 1 Aug 2018

You need @rdeutz to fix drone if we do this (i can't see this step in the drone yml file)

avatar rdeutz
rdeutz - comment - 1 Aug 2018

it is in the prepare step npm install does the trick via the postinstall script

avatar dgrammatiko
dgrammatiko - comment - 1 Aug 2018

@rdeutz do I have to patch something here?

avatar wilsonge wilsonge - change - 6 Aug 2018
Status Pending ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2018-08-06 09:45:19
Closed_By ⇒ wilsonge
avatar wilsonge wilsonge - close - 6 Aug 2018
avatar wilsonge wilsonge - merge - 6 Aug 2018
avatar wilsonge
wilsonge - comment - 6 Aug 2018

Thanks!

Add a Comment

Login with GitHub to post a comment