? Pending

User tests: Successful: Unsuccessful:

avatar ReLater
ReLater
1 Aug 2018

Pull Request for Issue #21160

This file was provided by @mbabker (https://gist.github.com/mbabker/5e171b1df99f71a30290125e0292b1d9).

I only created this pr.

Summary of Changes

mbabker:

We're going to have to get tricky with this file. The intent is to overload the core classes, so as they're now namespaced, the overloading has to use the correct namespacing as well. I think this is right (there are no IDE reported errors and no reported syntax errors linting the file), but I never write files using multiple namespaces, so I have no idea if this is going to do what we want it to.

Testing Instructions

I've tested it like this. The dilettantish way:

  • See #21211 and #21160

  • Install a nightly build 4.0 or alpha.

  • Download the nightly full package and also the update package 4.0.

  • Go to Joomla Update > Tabulator Upload&Update.

  • Try to update with one of the downloaded packages.
    You'll get an AJAX Error.

  • Extract the downloaded packages and exchange administrator/components/com_joomlaupdate/restore_finalisation.php with the file of this pr.

  • Zip the packages.

  • Repeat the steps above.

  • No AJAX error. Update successful.

avatar ReLater ReLater - open - 1 Aug 2018
avatar ReLater ReLater - change - 1 Aug 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 1 Aug 2018
Category Administration com_joomlaupdate
avatar ReLater ReLater - change - 1 Aug 2018
The description was changed
avatar ReLater ReLater - edited - 1 Aug 2018
avatar ReLater ReLater - change - 1 Aug 2018
The description was changed
avatar ReLater ReLater - edited - 1 Aug 2018
avatar ReLater ReLater - change - 1 Aug 2018
The description was changed
avatar ReLater ReLater - edited - 1 Aug 2018
avatar ReLater ReLater - change - 1 Aug 2018
The description was changed
avatar ReLater ReLater - edited - 1 Aug 2018
avatar ReLater ReLater - change - 1 Aug 2018
The description was changed
avatar ReLater ReLater - edited - 1 Aug 2018
avatar ReLater ReLater - change - 1 Aug 2018
The description was changed
avatar ReLater ReLater - edited - 1 Aug 2018
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 1 Aug 2018

At "Upload&Update" got:

screen shot 2018-08-01 at 06 16 00

But i guess its about zipping as there are different Sizes at modified (17,9MB) and original (13,3MB) zip:

screen shot 2018-08-01 at 06 18 19

System information

  • Nightly Build 4.0.0-alpha5-dev
  • Multilingual Sample Data (French, German DE, Persian)
  • Template: Cassiopeia
  • macOS Sierra, 10.13.6
  • Firefox 61 (64-bit)

CloudAccess.net

  • PHP 7.1.15
  • MySQLi 5.7.18-cll-lve
avatar wilsonge wilsonge - change - 6 Aug 2018
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2018-08-06 09:46:37
Closed_By wilsonge
Labels Added: ?
avatar wilsonge wilsonge - close - 6 Aug 2018
avatar wilsonge wilsonge - merge - 6 Aug 2018

Add a Comment

Login with GitHub to post a comment