? Pending

User tests: Successful: Unsuccessful:

avatar zero-24
zero-24
31 Jul 2018

Pull Request for Issue joomlagerman/joomla#437

Summary of Changes

Make sure automatic title is enabled by default like we had it in 2.5

Testing Instructions

Install this branch and confirm that the setting Automatic Title is enabled for Popular Articles, Recently Added Articles & Logged-in Users

Expected result

The setting is enabled and shows the generated title instead of the default.

Actual result

The setting is disabled and just the original title is displayed.

Documentation Changes Required

none.

avatar zero-24 zero-24 - open - 31 Jul 2018
avatar zero-24 zero-24 - change - 31 Jul 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 31 Jul 2018
Category SQL Installation Postgresql MS SQL
avatar brianteeman
brianteeman - comment - 31 Jul 2018

I am assuming this is related to the admin modules

IIRC it was a deliberate decision not to make them automatic and as you say it has been the case since 3.0

Note that the only reason for the automatic title was to allow the language to change automatically and the admin modules now support languages correctly

avatar zero-24
zero-24 - comment - 31 Jul 2018

How can a language pack do/use this? Thanks

avatar brianteeman
brianteeman - comment - 31 Jul 2018

it is defined in the helper for the module - best to read the code as you will understand it better than I can explain it

avatar Bakual
Bakual - comment - 31 Jul 2018

IIRC it was a deliberate decision not to make them automatic and as you say it has been the case since 3.0

As for the history:

  • J3 didn't have the "automatic title" feature anymore (that one which dynamically says "Last 5 articles" instead of "Last articles").
  • With 3.4.2 (#5793), the installation SQL file got adjusted to reflect that.
  • With 3.5.0, the feature was reintroduced (#7925), but the installation SQL didn't get changed back.

Thus all sites created prior to 3.4.2 have the automatic title enabled by default and translation (which is a nice sideeffect) works. Sites created after 3.4.2 have it disabled.

it is defined in the helper for the module - best to read the code as you will understand it better than I can explain it

If you refer to the getTitle function in the helper, that's exactly what this PR tries to enabled. That method is only called if automatic_title is enabled.

avatar brianteeman
brianteeman - comment - 31 Jul 2018

For me the main problem with the automatic titles is that they are not intuitive and they do not reflect the entry in the title field. So if automatic titles was enabled by default the user is confused why the title of the module doesnt reflect what is output on the screen.

I can't find it right now but i had an issue to remove this functionality completely but someone pointed it out its use in multilingual sites and it was rejected. As we can now have language specific modules its no longer the only option

avatar SharkyKZ
SharkyKZ - comment - 1 Aug 2018

If this is accepted, make the changes in module files, not in SQL files, please.

avatar infograf768
infograf768 - comment - 1 Aug 2018

@zero-24
I know why it was taken off in the first place. It was an accident when a PR by Kyle was merged.
I quote Hannes in https://groups.google.com/forum/#!msg/joomla-dev-cms/0P6NMtWnYeE/vap2bdgeB0AJ :
"It was most likely removed by accident while the backend was rewritten
to Bootstrap code. The commit where this was removed has more than 300
files and several thousand changed lines of code. The feature was part
of a view file that was overwritten, but the option was not removed from
the XML files of the modules. "

Once enabled in the Advanced tab of the modules concerned, it works like a charm.
The strings exist in all language packs. Example for mod_logged.

MOD_LOGGED_TITLE="Last Logged-in Users"
MOD_LOGGED_TITLE_1="Last Logged-in User"
MOD_LOGGED_TITLE_MORE="Last %s Logged-in Users"

Imho, it is a nice effect and saves creating similar modules for each language installed.

screen shot 2018-08-01 at 08 25 04

screen shot 2018-08-01 at 08 28 48

I am in favour of re-introducing it by default in joomla.sql

avatar brianteeman
brianteeman - comment - 1 Aug 2018

No dispute it can be useful but I would not make it the default after all these years.

avatar Bakual
Bakual - comment - 1 Aug 2018

If this is accepted, make the changes in module files, not in SQL files, please.

The SQL files are the correct place to set the initial values for new installations. If you change the default values in the modules it would change behavior on existing sites if they haven't stored the parameters.
So this PR is correct in that regard.

avatar zero-24 zero-24 - change - 1 Aug 2018
Labels Added: ?
avatar zero-24
zero-24 - comment - 4 Sep 2018

@mbabker can you take a look here and share your thoughts about this one?

avatar mbabker
mbabker - comment - 4 Sep 2018

Never used the feature so have no opinion either way. But if it's been turned off for the entirety of 3.x we shouldn't turn it on now.

avatar zero-24
zero-24 - comment - 4 Sep 2018

Ok I'm going to check if there is a way to override that in the language pack full install and close this here. Thanks!

avatar zero-24 zero-24 - change - 4 Sep 2018
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2018-09-04 11:40:41
Closed_By zero-24
avatar zero-24 zero-24 - close - 4 Sep 2018

Add a Comment

Login with GitHub to post a comment