J4 Issue ?
avatar dgrammatiko
dgrammatiko
14 May 2018

Web components and Custom elements are also ES6

Since we already have a PR for merging the ongoing work from the ES6-javascript group to the main repo I would like to propose one more change for the shake of consistency but also (IMHO) simplifying the contributors workflow:

Unify the source code of the ES6 (plain) files with those of the web components/custom elements. Right now web components source is living in the /build/webcomponents folder. So my proposal will be to expose another root directory, eg media_src with all the source files (js and scss but also images and have one more method to smash them down, already plenty of such scripts in the npmjs). This in combination to our ultimate goal having only source in the main repo will unify things (in plain english I'm proposing to build the whole media folder through our existing/improved tools, already just one simple line on the terminal: npm install).

avatar dgrammatiko dgrammatiko - open - 14 May 2018
avatar joomla-cms-bot joomla-cms-bot - change - 14 May 2018
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 14 May 2018
avatar franz-wohlkoenig franz-wohlkoenig - change - 15 May 2018
Status New Discussion
avatar franz-wohlkoenig franz-wohlkoenig - change - 15 May 2018
Category JavaScript
avatar brianteeman brianteeman - change - 16 May 2018
Labels Added: J4 Issue
avatar brianteeman brianteeman - labeled - 16 May 2018
avatar laoneo
laoneo - comment - 18 May 2018

Sounds like a good plan. But then I would name the the source folder assets_src to reflect better what it actually is.

avatar mbabker
mbabker - comment - 18 May 2018

Put it in the build folder.

We don't need another top level directory in the repository.

avatar dgrammatiko dgrammatiko - change - 29 Aug 2018
Status Discussion Closed
Closed_Date 0000-00-00 00:00:00 2018-08-29 10:22:21
Closed_By dgrammatiko
avatar dgrammatiko dgrammatiko - close - 29 Aug 2018

Add a Comment

Login with GitHub to post a comment