? Pending

User tests: Successful: Unsuccessful:

avatar dgrammatiko
dgrammatiko
14 May 2018

Issue: #20389

Summary of Changes

Standard forms dont require inline js for validation, they only require a class form-validate!

Testing Instructions

Apply patch and try to edit a module in the frontend. Save, Save and close and Close buttons should behave normally. Also check that editing the article also works

BTW, I've applied the same code to the rest views of com_config and also com_content

Expected result

screen shot 2018-05-14 at 20 37 53

Actual result

Documentation Changes Required

At some point we really need to document this submitbutton...

@wilsonge

avatar dgrammatiko dgrammatiko - open - 14 May 2018
avatar dgrammatiko dgrammatiko - change - 14 May 2018
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 14 May 2018
Category Front End com_config com_content
avatar Quy
Quy - comment - 14 May 2018

This one #20389 ?

avatar dgrammatiko
dgrammatiko - comment - 14 May 2018

@Quy thanks that's the one

avatar dgrammatiko dgrammatiko - change - 14 May 2018
The description was changed
avatar dgrammatiko dgrammatiko - edited - 14 May 2018
avatar wilsonge wilsonge - change - 14 May 2018
Labels Added: ?
avatar carlitorweb
carlitorweb - comment - 14 May 2018

I tested this successful, just waiting for the drone fix

avatar infograf768
infograf768 - comment - 15 May 2018

Successful here too

avatar laoneo
laoneo - comment - 15 May 2018

The drone tests are because of some other issues.

avatar laoneo laoneo - change - 16 May 2018
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2018-05-16 07:43:02
Closed_By laoneo
avatar laoneo laoneo - close - 16 May 2018
avatar laoneo laoneo - merge - 16 May 2018

Add a Comment

Login with GitHub to post a comment