[#20396] - [4.0] Migrate scripts to es6
- Fixed in Code Base
- 17 May 2018
- Medium
- Build: 4.0-dev
- # 20396
- Diff
- Digital-Peak:j4/es6
User tests: Successful: Unsuccessful:
After the decision to migrate the javascript script code base to ES6 by merging pr #19650, this pr is the work of the Javascript team to migrate a first stack of files to ES6. Beside that some inline scripts got removed and jQuery to vanilla conversion was done.
If this gets merged, then changes to javascript files need to be done in the *.es6.js file only. Afterwards the javascript code needs to be transpiled to es5 with the following command:
node build/build-modules-js/compile-es6.js
To minify then the es5 file you have to run:
node build.js --compilejs
Credits goes to:
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Unit Tests Administration com_cache com_content com_fields com_finder com_joomlaupdate com_languages com_menus com_plugins com_redirect Modules JavaScript Repository Front End com_config com_contact com_mailto com_newsfeeds com_tags |
| Labels |
Added:
?
?
|
||
We need to fix the hound errors before this gets merged
Were failing system tests here
Joomla is very not defined :)
You need to run the compiler (npm run build:js). Things like core.min.js have been removed and therefore it doesn't work
we should have a quick reply for this as it will come up a LOT
On 15 May 2018 at 16:09, George Wilson notifications@github.com wrote:
You need to run the compiler. Things like core.min.js have been removed
and therefore it doesn't work—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#20396 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8apFRHPk3eclQp402b9HvmqD-fmFks5tyu-sgaJpZM4T9zdc
.
--
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
https://brian.teeman.net/ http://brian.teeman.net/
Until we have the PR testing platform ready to go we aren't removing minified files from the repo... they need to be added back for now.
But yeah i get your point when we do eventually do it we'll have quite a few issues like this :)
Added the min files. Now all should be fine.
Perfect. Fix the conflicts here and let's get this in :)
Fixed conflicts. Please do not squash the pr.
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2018-05-17 22:35:54 |
| Closed_By | ⇒ | wilsonge |
A big thank you to all the people @laoneo mentioned above but he forgot to include himself!
Couple notes here:
Now this might translate to 12.5% but that is not exactly the truth. The reasons are: