[#20231] - Make user field initialize itself when a new subform row is added
- Fixed in Code Base
- 29 May 2019
- Medium
- Build: staging
- # 20231
- Diff
- okonomiyaki3000:fix-subform-user
- Success Hound No violations found. Woof! Details
- Success continuous-integration/drone/pr the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Failure continuous-integration/appveyor/pr AppVeyor build failed Details
- Pending JTracker/HumanTestResults Human Test Results: 1 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
Subform repeatable has a function fixScripts which calls a few js initialization functions on a few of the field types that require it. There is a now a better way to handle that kind of thing by having any field that may need initialization listen for an event fired by subform repeatable. In this PR, I am transferring responsibility of one such initialization from subform repeatable to the correct field type itself.
Note: this PR doesn't really fix anything. the user field type already works with repeatable subforms. This just does it in a somewhat better way.
Testing Instructions
Set up a subform containing a user field. There's a subform in the redirect plugin that's simple to use for this purpose.
Open up the form and create new rows. The user field in each new row should function properly.
Expected result
User field functions normally.
Actual result
User field functions normally.
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript |
| Labels |
Removed:
J3 Issue
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20231.
@okonomiyaki3000 could you please solve the conflicts?
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-05-29 11:09:33 |
| Closed_By | ⇒ | HLeithner |
I have tested this item✅ successfully on f2999be
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20231.