[#20232] - Make squeezebox initialize itself when a new subform row is added
- Fixed in Code Base
- 15 May 2019
- Medium
- Build: staging
- # 20232
- Diff
- okonomiyaki3000:fix-subform-squeezebox
- Success Hound No violations found. Woof! Details
- Success continuous-integration/drone/pr the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
Subform repeatable has a function fixScripts which calls a few js initialization functions on a few of the field types that require it. There is a now a better way to handle that kind of thing by having any field that may need initialization listen for an event fired by subform repeatable. In this PR, I am transferring responsibility of one such initialization from subform repeatable to the correct field type itself.
Note: this PR doesn't really fix anything. Fields that use squeezebox already work with repeatable subforms. This just does it in a somewhat better way.
Another note: Squeezebox uses mootools and is deprecated. Bootstrap modals are prefered. Still, as long as some fields use it, they should use it like this.
Testing Instructions
Set up a subform containing a field that uses squeezebox (for example contenthistory). There's a subform in the redirect plugin that's simple to use for this purpose.
Open up the form and create new rows. The field in each new row should function properly.
Expected result
Fields that use squeezebox function normally.
Actual result
Fields that use squeezebox function normally.
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries JavaScript |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20232.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20232.
@HLeithner please a final response
1 year old rtc pr
| Labels |
Removed:
J3 Issue
|
||
| Labels |
Added:
?
|
||
I think it makes no sense merging this if it fix nothing and subforms doesn't exists anylonger in j4. ymmv
| Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-05-10 12:42:44 |
| Closed_By | ⇒ | HLeithner |
Wait... subforms don't exist anymore?
@HLeithner you're getting confused here. subforms do exist :) these are the xml attributes. subfields you're linking to are just subforms as a custom field
| Status | Closed | ⇒ | New |
| Closed_Date | 2019-05-10 12:42:44 | ⇒ | |
| Closed_By | HLeithner | ⇒ | |
| Labels |
Removed:
?
|
||
| Status | New | ⇒ | Pending |
So we're still doing this, right?
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20232.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-05-15 08:44:41 |
| Closed_By | ⇒ | HLeithner | |
| Labels |
Added:
?
|
||
thx
I have tested this item✅ successfully on 41229fd
Tested with the Redirect plugin.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/20232.